Uh oh!
There was an error while loading. Please reload this page.
[log] Add debug logging to guard-policy, arc-dind, and validation helpers - #51298
Conversation
Adds pkg:filename-namespaced logger.New declarations to two previously unlogged files (compile_guard_policy_report.go, awf_arc_dind.go) and extends three minimally-logged files with additional debug points at key decision branches (version gating, root-requiring pattern checks, allowed-labels glob validation, and main job step phases).
gh-aw-bot
commented
Aug 8, 2026
@copilot Quick triage nudge for this PR. Please refresh the branch if GitHub can update it cleanly, address the remaining items below, and run the Open items (newest first):
Branch refresh was requested. Run: https://github.com/github/gh-aw/actions/runs/31239156270
|
Branch is current with |
Thanks for this logging enhancement! 📝 The changes look focused and well-intentioned. Here are a couple of items to strengthen the PR: Test Coverage for Logging
CI Validation
Once test coverage is added or CI validation confirms the build is clean, this should be ready for review. The logging structure and namespace convention are solid!
|
🎉 This pull request is included in a new release. Release: |
Overview
Adds namespace-based debug logging (
pkg/logger) to five files across the CLI and workflow compiler packages. All changes are additive instrumentation gated by theDEBUGenvironment variable — no functional or output behavior changes, except one no-op early-return guard.Files changed
pkg/cli/compile_guard_policy_report.gocli:compile_guard_policy_reportpkg/workflow/awf_arc_dind.goworkflow:awf_arc_dindpkg/workflow/compiler_yaml_main_job.gocompilerYamlLog)pkg/workflow/runner_topology_validation.gorunnerTopologyValidationLog)pkg/workflow/safe_outputs_allowed_labels_validation.gosafeOutputsAllowedLabelsValidationLog)allowed-labelsfields are configured, plus a log line for the number of fields validated.Behavior notes
DEBUG=*or scoped namespaces (e.g.DEBUG=cli:compile_guard_policy_report); no output changes in normal (non-debug) runs.safe_outputs_allowed_labels_validation.gois a no-op optimization: with zero configs, the subsequent loop would not execute andnilwould already be returned at the end — no observable behavior change.