Detect typed map[string]bool set aliases in short declarations

[Copilot]

seenmapbool only considered := declarations when the RHS was a literal make(map[string]bool) or composite literal. Typed maps returned by helpers or copied from variables were silently skipped.

• Candidate detection

  • Use the declared identifier type as the sole := eligibility check.
  • Remove redundant RHS AST-shape checks.

• Regression coverage

  • Diagnose helper-returned maps.
  • Diagnose maps copied from map[string]bool parameters.

seen:=getSeenMap() // now diagnosedseen["x"] =trueseen:=other// now diagnosedseen["x"] =true

• Fixesseenmapbool: := candidate gate requires literal make()/composite RHS, causing false negatives for map[string]bool sets built a [Content truncated due to length] #51300

[github-actions]

Great work! 🎉 This fix to the seenmapbool linter properly addresses the under-detection gap in issue #51300.

The change is well-scoped — removing the redundant RHS AST-shape check and relying solely on the type system to identify eligible map[string]bool variables, just like the var branch already does. The regression test coverage (helper-returned maps and variable copies) is exactly what was needed.

The simplification from 38 deleted lines and 2 added lines shows this was a clean fix that removed unnecessary complexity rather than adding new logic. The diff balances well with the test expansion.

This PR looks ready for review. Nice work aligning the := and var candidate detection paths!

Generated by ✅ Contribution Check · auto · 58.8 AIC · ⌖ 3.48 AIC · ⊞ 8.7K · ◷

[Copilot]

Pull request overview

Updates seenmapbool to detect typed map[string]bool values initialized from helpers or variables.

Changes:

• Uses identifier types instead of RHS syntax for candidate detection.
• Removes obsolete AST-shape helpers.
• Adds regression cases for helper returns and map copies.

Show a summary per file

File	Description
pkg/linters/seenmapbool/seenmapbool.go	Broadens short-declaration candidate detection.
pkg/linters/seenmapbool/testdata/src/seenmapbool/seenmapbool.go	Adds regression coverage for newly detected patterns.

Review details

Tip

Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Balanced

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.86.2