Skip to content

Add mobile interaction regression test for the home page quick-start CTA - #51323

Merged
pelikhan merged 2 commits into
mainfrom
copilot/multi-device-docs-testing-report-again
Aug 8, 2026
Merged

Add mobile interaction regression test for the home page quick-start CTA#51323
pelikhan merged 2 commits into
mainfrom
copilot/multi-device-docs-testing-report-again

Conversation

CopilotAI commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

The multi-device docs test report flagged mobile interaction warnings suggesting the hero quick-start CTA may be obscured or non-tappable after the navigation drawer is opened/dismissed, and recommended a responsive interaction regression test at mobile breakpoints.

No production defect was reproducible — this adds coverage to lock in the current behavior.

Changes

  • docs/tests/mobile-responsive.spec.ts — new parameterized test at 360px / 393px / 428px viewports covering the full mobile interaction path:
    • CTA is visible and points at /gh-aw/setup/quick-start/
    • CTA is the topmost hit-testable element at its centre (catches overlays, sticky header, or the hero slide canvas intercepting taps)
    • hamburger menu opens, Escape dismisses it, aria-expanded resets, dropdown hidden
    • CTA is re-hit-tested after dismissal and actually navigates

The hit-test is the meaningful assertion — toBeVisible() alone would not catch a leftover overlay swallowing the tap:

constisTopmost=awaitpage.evaluate(([x,y])=>{constel=document.elementFromPoint(x,y);constctaEl=document.querySelector('.hero a.sl-link-button.primary');return!!el&&!!ctaEl&&(el===ctaEl||ctaEl.contains(el));},[box.x+box.width/2,box.y+box.height/2]);

Test-only change; no site source or styles were modified.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI changed the title [WIP] Update multi-device testing report for 2026-08-08Add mobile interaction regression test for the home page quick-start CTAAug 8, 2026
CopilotAI requested a review from pelikhanAugust 8, 2026 06:04
@pelikhan
pelikhan marked this pull request as ready for review August 8, 2026 06:24
CopilotAI balanced review requested due to automatic review settings August 8, 2026 06:24
@pelikhan
pelikhan merged commit fb3befa into mainAug 8, 2026
1 check passed
@pelikhan
pelikhan deleted the copilot/multi-device-docs-testing-report-again branch August 8, 2026 06:24

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds mobile regression coverage for the homepage quick-start CTA after menu interaction.

Changes:

  • Tests CTA visibility, hit-testing, menu dismissal, and navigation across three mobile widths.
  • Verifies menu accessibility state resets after Escape.
Show a summary per file
FileDescription
docs/tests/mobile-responsive.spec.tsAdds parameterized mobile CTA interaction tests.

Review details

Tip

Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Suppressed comments (1)

docs/tests/mobile-responsive.spec.ts:428

  • This uses Playwright's mouse click(), while the manually created context defaults to hasTouch: false. As a result, the regression test does not exercise the touch/tap navigation promised by its name and the PR description, so a touch-specific failure would still pass. Configure the context with touch/mobile emulation (preferably a device descriptor) and navigate with cta.tap().
 await cta.click();
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced


await expectCtaHittable();

// Open the mobile navigation menu, then dismiss it by clicking outside.
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.86.2

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔍 Multi-Device Docs Testing Report - 2026-08-08

3 participants

@pelikhan