Uh oh!
There was an error while loading. Please reload this page.
Add mobile interaction regression test for the home page quick-start CTA - #51323
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Update multi-device testing report for 2026-08-08Add mobile interaction regression test for the home page quick-start CTAAug 8, 2026
pelikhan
marked this pull request as ready for review
August 8, 2026 06:24
Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds mobile regression coverage for the homepage quick-start CTA after menu interaction.
Changes:
- Tests CTA visibility, hit-testing, menu dismissal, and navigation across three mobile widths.
- Verifies menu accessibility state resets after Escape.
Show a summary per file
| File | Description |
|---|---|
docs/tests/mobile-responsive.spec.ts | Adds parameterized mobile CTA interaction tests. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (1)
docs/tests/mobile-responsive.spec.ts:428
- This uses Playwright's mouse
click(), while the manually created context defaults tohasTouch: false. As a result, the regression test does not exercise the touch/tap navigation promised by its name and the PR description, so a touch-specific failure would still pass. Configure the context with touch/mobile emulation (preferably a device descriptor) and navigate withcta.tap().
await cta.click();
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
| await expectCtaHittable(); | ||
| // Open the mobile navigation menu, then dismiss it by clicking outside. |
Contributor
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multi-device docs test report flagged mobile interaction warnings suggesting the hero quick-start CTA may be obscured or non-tappable after the navigation drawer is opened/dismissed, and recommended a responsive interaction regression test at mobile breakpoints.
No production defect was reproducible — this adds coverage to lock in the current behavior.
Changes
docs/tests/mobile-responsive.spec.ts— new parameterized test at 360px / 393px / 428px viewports covering the full mobile interaction path:/gh-aw/setup/quick-start/Escapedismisses it,aria-expandedresets, dropdown hiddenThe hit-test is the meaningful assertion —
toBeVisible()alone would not catch a leftover overlay swallowing the tap:Test-only change; no site source or styles were modified.