Uh oh!
There was an error while loading. Please reload this page.
Conversation
Hey I see this is still in draft with the planning checklist in progress. A few things to track as you move forward:
When you're ready to move this out of draft:
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
commented
Aug 11, 2026
@copilot resolve the merge conflicts on this branch. |
There was a problem hiding this comment.
Pull request overview
Adds scoped Runner Guard suppressions for benign localhost-only Ollama requests and introduces generic annotation filtering.
Changes:
- Adds exact-rule suppression filtering within workflow steps.
- Tests matching and mismatched rule IDs.
- Annotates and recompiles the Ollama workflow.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/runner_guard.go | Integrates annotation filtering. |
pkg/cli/runner_guard_gvisor_exfiltration.go | Implements suppression detection. |
pkg/cli/runner_guard_gvisor_exfiltration_test.go | Tests rule matching behavior. |
.github/workflows/daily-byok-ollama-test.md | Annotates three localhost requests. |
.github/workflows/daily-byok-ollama-test.lock.yml | Regenerates the compiled workflow. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 3
- Review effort level: Balanced
| for i := findingIndex; i >= 0; i-- { | ||
| trimmed := strings.TrimLeft(lines[i], " ") | ||
| if strings.HasPrefix(trimmed, "- ") { | ||
| stepStart = i | ||
| stepIndent = len(lines[i]) - len(trimmed) |
| if i > stepStart && indent == stepIndent && strings.HasPrefix(trimmed, "- ") { | ||
| break | ||
| } | ||
| annotationIndex := strings.Index(lines[i], annotation) |
| {RuleID: "RGS-012", File: "annotated.lock.yml", Line: 11}, | ||
| {RuleID: "RGS-018", File: "annotated.lock.yml", Line: 11}, |
pelikhan
commented
Aug 11, 2026
@copilot resolve the merge conflicts on this branch. |
…ecret-exfiltration # Conflicts: # .github/workflows/daily-byok-ollama-test.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…ecret-exfiltration Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Resolved in the latest merge commit. main had moved further ahead but this time it merged cleanly with no conflicts. |
pelikhan
commented
Aug 11, 2026
@copilot resolve the merge conflicts on this branch. |
…ecret-exfiltration # Conflicts: # .github/workflows/daily-byok-ollama-test.lock.yml # .github/workflows/daily-byok-ollama-test.md Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
gh-aw-bot
commented
Aug 11, 2026
@copilot please review the remaining feedback, refresh the branch if needed, rerun the relevant validation, and use the
|
Runner Guard misclassified three localhost-only Ollama requests as potential secret exfiltration.
Workflow
Scanner integration
# runner-guard:ignore RGS-012 -- localhost-only probe; no secrets are sent.