Skip to content

Suppress benign Ollama RGS-012 findings - #52050

Closed
pelikhan with Copilot wants to merge 5 commits into
mainfrom
copilot/rgs-012-fix-secret-exfiltration
Closed

Suppress benign Ollama RGS-012 findings#52050
pelikhan with Copilot wants to merge 5 commits into
mainfrom
copilot/rgs-012-fix-secret-exfiltration

Conversation

CopilotAI commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Runner Guard misclassified three localhost-only Ollama requests as potential secret exfiltration.

  • Workflow

    • Add scoped RGS-012 annotations to Ollama readiness and warm-up requests.
    • Regenerate the compiled workflow.
  • Scanner integration

    • Honor exact rule annotations within the attributed workflow step.
    • Preserve findings for mismatched or prefix-colliding rule IDs.
# runner-guard:ignore RGS-012 -- localhost-only probe; no secrets are sent.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 8.97 AIC · ⌖ 6.37 AIC · ⊞ 8.5K ·
Comment /souschef to run again

@github-actions

Copy link
Copy Markdown
Contributor

Hey @Copilot 👋 — thanks for taking on the RGS-012 runner-guard security fix! This is important work.

I see this is still in draft with the planning checklist in progress. A few things to track as you move forward:

  • No code changes yet — The PR currently has 0 changed files and 0 additions/deletions. Once you add the RGS-012 suppressions to .github/workflows/daily-byok-ollama-test.lock.yml and recompile the lock-file, this will be populated.
  • Add tests — Once the suppressions are in place, consider adding validation tests to ensure the runner-guard suppressions work as intended (e.g., that the three localhost-only Ollama requests are correctly exempted from RGS-012 checks).
  • Follow the checklist — The PR checklist looks solid; make sure all four items are completed and verified before moving out of draft.

When you're ready to move this out of draft:

1. Add narrowly justified RGS-012 suppressions to `.github/workflows/daily-byok-ollama-test.lock.yml` for the three localhost-only Ollama requests (lines 488, 496, 501).
2. Recompile the workflow lock-file to verify suppressions are correctly integrated.
3. Run runner-guard and repository validation to confirm the RGS-012 findings are resolved.
4. Verify no other security issues are introduced by the changes.

Generated by ✅ Contribution Check · auto · 49.6 AIC · ⌖ 3.67 AIC · ⊞ 8.8K ·

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI changed the title [WIP] Fix secret exfiltration via outbound HTTP requestSuppress benign Ollama RGS-012 findingsAug 11, 2026
CopilotAI requested a review from pelikhanAugust 11, 2026 13:36
@pelikhan
pelikhan marked this pull request as ready for review August 11, 2026 13:43
CopilotAI balanced review requested due to automatic review settings August 11, 2026 13:43
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts on this branch.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds scoped Runner Guard suppressions for benign localhost-only Ollama requests and introduces generic annotation filtering.

Changes:

  • Adds exact-rule suppression filtering within workflow steps.
  • Tests matching and mismatched rule IDs.
  • Annotates and recompiles the Ollama workflow.
Show a summary per file
FileDescription
pkg/cli/runner_guard.goIntegrates annotation filtering.
pkg/cli/runner_guard_gvisor_exfiltration.goImplements suppression detection.
pkg/cli/runner_guard_gvisor_exfiltration_test.goTests rule matching behavior.
.github/workflows/daily-byok-ollama-test.mdAnnotates three localhost requests.
.github/workflows/daily-byok-ollama-test.lock.ymlRegenerates the compiled workflow.

Review details

  • Files reviewed: 5/5 changed files
  • Comments generated: 3
  • Review effort level: Balanced

Comment on lines +48 to +52
for i := findingIndex; i >= 0; i-- {
trimmed := strings.TrimLeft(lines[i], " ")
if strings.HasPrefix(trimmed, "- ") {
stepStart = i
stepIndent = len(lines[i]) - len(trimmed)
if i > stepStart && indent == stepIndent && strings.HasPrefix(trimmed, "- ") {
break
}
annotationIndex := strings.Index(lines[i], annotation)
Comment on lines +86 to +87
{RuleID: "RGS-012", File: "annotated.lock.yml", Line: 11},
{RuleID: "RGS-018", File: "annotated.lock.yml", Line: 11},
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts on this branch.

…ecret-exfiltration
# Conflicts:
#	.github/workflows/daily-byok-ollama-test.lock.yml
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

CopilotAI commented Aug 11, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot resolve the merge conflicts on this branch.

Resolved in d7a0b96. Only the compiled daily-byok-ollama-test.lock.yml conflicted; the .md source merged cleanly with the RGS-012 annotations intact, and I regenerated the lock file with make recompile.

…ecret-exfiltration
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

CopilotAI commented Aug 11, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot resolve the merge conflicts on this branch.

Resolved in the latest merge commit. main had moved further ahead but this time it merged cleanly with no conflicts.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts on this branch.

…ecret-exfiltration
# Conflicts:
#	.github/workflows/daily-byok-ollama-test.lock.yml
#	.github/workflows/daily-byok-ollama-test.md
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

CopilotAI commented Aug 11, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot resolve the merge conflicts on this branch.

Resolved in 12f384f. main had already merged a similar fix (#52083) with slightly different wording for the same three daily-byok-ollama-test.md annotations; kept that upstream wording and regenerated the lock file.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please review the remaining feedback, refresh the branch if needed, rerun the relevant validation, and use the pr-finisher skill before handing back.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 8.97 AIC · ⌖ 6.37 AIC · ⊞ 8.5K ·
Comment /souschef to run again

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[static-analysis] RGS-012: Secret Exfiltration via Outbound HTTP Request in daily-byok-ollama-test.lock.yml

4 participants

@pelikhan@gh-aw-bot