Extend confused deputy protection to pull_request_target by Copilot · Pull Request #52976 · github/gh-aw

Copilot · 2026-08-15T22:10:11Z

pull_request_target synchronize events bypassed the confused-deputy check applied to equivalent pull_request events, allowing a bot actor to differ from the PR author.

Detection
- Apply actor-to-author validation to both PR event types:
```
eventName==="pull_request"||eventName==="pull_request_target"
```
- Preserve existing bot-only and synchronize-only safeguards.
Coverage
- Add cases for mismatched bot actors, matching PR authors, and legitimate human collaboration.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Extends confused-deputy protection to pull_request_target synchronization events.

Changes:

Applies bot actor-to-PR-author validation to both PR event types.
Adds coverage for malicious mismatches and legitimate actors.

Show a summary per file

File	Description
`actions/setup/js/check_permissions_utils.cjs`	Extends event validation to `pull_request_target`.
`actions/setup/js/check_permissions_utils.test.cjs`	Tests matching, mismatched, and human actors.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Files reviewed: 2/2 changed files
Comments generated: 0
Review effort level: Balanced

github-actions · 2026-08-15T22:56:02Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #52976 does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-08-15T22:56:03Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-08-15T22:56:10Z

✅ Ponytail Reviewer completed successfully!

Lean already. Ship.

Generated by Ponytail Reviewer for #52976

github-actions · 2026-08-15T22:56:10Z

✅ PR Code Quality Reviewer completed the code quality review.

Reviewed PR #52976 locally; no actionable review comments or GitHub writes were needed because the patch is a narrow correctness fix with targeted tests and I found no blocking issues.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-08-15T22:56:23Z

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

github-actions

The change is correct and well-tested. Extending the confused deputy guard to pull_request_target is the right call — that trigger runs in the base-branch context with write permissions, making it more susceptible to the attack, not less. The three new test cases cover all relevant scenarios (bot-mismatch → true, bot-match → false, human → false). No issues found.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 14.3 AIC · ⌖ 7 AIC · ⊞ 5.6K

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs and /tdd — one minor gap in test coverage, otherwise approving.

📋 Key Themes & Highlights

Key Themes

Security fix is correct: The one-line condition change (|| eventName === "pull_request_target") is minimal and precisely closes the bypass.
Test coverage is good but not complete: Three new tests cover the attack case, the safe case, and the human-collaborator case. The only gap is a non-synchronize action for pull_request_target, which the pull_request suite already covers.

Positive Highlights

✅ Root cause properly addressed — the condition now mirrors pull_request exactly.
✅ Comment updated to reflect both event types.
✅ Tests read as specifications (clear arrange/act/assert, descriptive names).
✅ No collateral changes — the fix is surgical.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 23.6 AIC · ⌖ 8.95 AIC · ⊞ 7.7K
_{Comment /matt to run again}

github-actions · 2026-08-15T23:00:54Z

+
 it("should return false for pull_request_review when actor matches review author (genuine review)", () => {
 const payload = {
 pull_request: { user: { login: "pr-author" } },


[/tdd] Missing edge case: no test covers pull_request_target with a non-synchronize action (e.g. labeled). The existing pull_request suite has an equivalent case — adding one here fully mirrors coverage and guards against future regressions if the condition logic changes.
💡 Suggested test
it("should return false for pull_request_target:labeled (non-synchronize action)",()=>{constpayload={action: "labeled",pull_request: {user: {login: "alice"}}};expect(isConfusedDeputyAttack("dependabot[bot]","pull_request_target",payload)).toBe(false);});
@copilot please address this.

Added the non-synchronizepull_request_target:labeled coverage in 4866db1. The focused setup JS test and make agent-report-progress both pass locally.

github-actions · 2026-08-15T23:02:42Z

🧪 Test Quality Sentinel Report

✅ Test Quality Score: 90/100 — Excellent

Analyzed 3 test(s): 3 design, 0 implementation, 0 violation(s).

📊 Metrics (3 tests)

Metric	Value
Analyzed	3 (Go: 0, JS: 3)
✅ Design	3 (100%)
⚠️ Implementation	0 (0%)
Edge/error coverage	3 (100%)
Duplicate clusters	0
Inflation	Yes (5:1 ratio)
🚨 Violations	0

Test	File	Classification	Notes
`pull_request_target:synchronize` bot actor differs from PR author	check_permissions_utils.test.cjs:790	design_test, high_value	✅ Detects confused deputy security invariant
`pull_request_target:synchronize` bot actor matches PR author	check_permissions_utils.test.cjs:795	design_test, high_value	✅ Prevents false positives on legitimate bot behavior
`pull_request_target:synchronize` human collaborator	check_permissions_utils.test.cjs:800	design_test, high_value	✅ Validates legitimate human collaboration

Analysis

This PR extends confused deputy attack detection to pull_request_target events. The three new test cases provide comprehensive coverage:

Primary invariant (test:1): Detects the security issue when a bot actor differs from the PR author on pull_request_target:synchronize events
False positive prevention (test:2): Legitimate bots that are the PR author are not flagged
Human collaboration (test:3): Human team members pushing to PRs they don't own remains allowed (permissions are validated separately)

All tests are behavioral contracts enforcing the security design, not implementation details. The 5:1 test-to-production ratio is justified: expanding event-type coverage from pull_request → {pull_request, pull_request_target} requires new test rows. No padding or redundant assertions detected.

Verdict

✅ passed. 0% implementation tests (threshold: 30%). All new tests enforce security invariants with high behavioral value.

🧪 Test quality analysis by Test Quality Sentinel · haiku45 · 24.4 AIC · ⌖ 3.31 AIC · ⊞ 7.9K · ◷
_{Comment /review to run again}

github-actions

✅ Test Quality Sentinel: 90/100 (Excellent). 0% implementation tests (threshold: 30%). All new tests enforce security invariants with high behavioral value.

pelikhan · 2026-08-15T23:12:06Z

@copilot fix lint js https://github.com/github/gh-aw/actions/runs/31912360371/job/95081870383?pr=52976

gh-aw-bot · 2026-08-15T23:20:05Z

@copilot Quick triage for maintainer-ready follow-up:

Please refresh the branch if needed, fix the remaining failed check, and run the pr-finisher skill before handing this PR back to maintainers.

Outstanding review items (newest first):

No unresolved reviewer follow-up was found in the current compact triage context.

Failed checks from the compact candidate set:

Branch update was requested automatically for this run when GitHub allows it.
Run context: https://github.com/github/gh-aw/actions/runs/31914206398

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.56 AIC · ⌖ 6.97 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-08-15T23:22:23Z

@copilot fix lint js https://github.com/github/gh-aw/actions/runs/31912360371/job/95081870383?pr=52976

Fixed in e3d851e6aa. make agent-report-progress now passes, including JS lint and eslint-factory tests.

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-08-15T23:30:45Z

@copilot Quick triage for maintainer-ready follow-up:
Please refresh the branch if needed, fix the remaining failed check, and run the pr-finisher skill before handing this PR back to maintainers....

Completed pr-finisher pass in 4866db1.

Reviews: addressed the remaining GitHub Actions review thread by adding pull_request_target:labeled coverage.
Checks: prior lint-js failures were root-caused to Prettier formatting and fixed in e3d851e; local make agent-report-progress passes on the current branch.
Mergeability: PR is open and not draft; no branch refresh was indicated as required by the PR API.

CI on the agent-pushed HEAD is stale and needs a maintainer re-trigger before merge.

github-actions · 2026-08-16T00:55:24Z

🎉 This pull request is included in a new release.

Release: v0.87.0

Harden pull request target confused deputy checks
ccc6fb6
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

CopilotAI assigned Copilot and pelikhan Aug 15, 2026

CopilotAI requested a review from pelikhan August 15, 2026 22:10

Copilotfinished work on behalf of pelikhan August 15, 2026 22:10

Copilotcreated this pull request from a session on behalf of pelikhan August 15, 2026 22:10 View session

pelikhan marked this pull request as ready for review August 15, 2026 22:31

CopilotAI balanced review requested due to automatic review settings August 15, 2026 22:31

Copilotstarted reviewing on behalf of pelikhan August 15, 2026 22:32 View session

CopilotAI reviewed Aug 15, 2026
View reviewed changes

github-actionsBot mentioned this pull request Aug 15, 2026
[pr-sous-chef] PR Sous Chef run report #52798
Closed

github-actionsBot approved these changes Aug 15, 2026
View reviewed changes

github-actionsBot mentioned this pull request Aug 15, 2026
[aw] No-Op Runs #48838
Open

github-actionsBot approved these changes Aug 15, 2026
View reviewed changes

Copilotstarted work on behalf of pelikhan August 15, 2026 23:12 View session

Fix JS lint validation failures
e3d851e
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilotfinished work on behalf of pelikhan August 15, 2026 23:22

Copilotstarted work on behalf of gh-aw-bot August 15, 2026 23:23 View session

Add pull request target non-synchronize coverage
4866db1
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilotfinished work on behalf of gh-aw-bot August 15, 2026 23:31

CopilotAI requested a review from gh-aw-bot August 15, 2026 23:31

pelikhan merged commit 3cf910d into mainAug 15, 2026
8 of 9 checks passed

pelikhan deleted the copilot/extend-isconfuseddeputyattack branch August 15, 2026 23:43

github-actionsBot mentioned this pull request Aug 16, 2026
[Outcome Report] Workflow Health — 2026-08-16 #52996
Closed

github-actionsBot mentioned this pull request Aug 17, 2026
[blog] Weekly blog post – 2026-08-17 #53281
Merged

Uh oh!

Conversation

CopilotAI commented Aug 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actionsBot commented Aug 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Aug 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Aug 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Aug 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Aug 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Uh oh!

github-actionsBotAug 15, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIAug 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Aug 15, 2026

🧪 Test Quality Sentinel Report

Analysis

Verdict

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Aug 15, 2026

Uh oh!

gh-aw-bot commented Aug 15, 2026

Uh oh!

CopilotAI commented Aug 15, 2026

Uh oh!

CopilotAI commented Aug 15, 2026

Uh oh!

Uh oh!

github-actionsBot commented Aug 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CopilotAI commented Aug 15, 2026•
edited
Loading

github-actionsBot commented Aug 15, 2026•
edited
Loading

github-actionsBot commented Aug 15, 2026•
edited
Loading

github-actionsBot commented Aug 15, 2026•
edited
Loading

github-actionsBot commented Aug 15, 2026•
edited
Loading

github-actionsBot commented Aug 15, 2026•
edited
Loading