Uh oh!
There was an error while loading. Please reload this page.
Allow target in safe-outputs.create-check-run frontmatter schema - #53113
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
target in safe-outputs.create-check-run frontmatter schemapelikhan
commented
Aug 16, 2026
@copilot do this work: The issue also proposes extending scripts/check-safe-outputs-conformance.sh to assert that every yaml: tag on a safe-output config struct has a matching schema property, which would catch this class of drift rather than each instance. |
There was a problem hiding this comment.
Pull request overview
Adds schema support for safe-outputs.create-check-run.target, aligning validation with compiler behavior and documentation.
Changes:
- Declares the
targetstring property. - Adds regression coverage for schema validation.
Show a summary per file
| File | Description |
|---|---|
pkg/parser/schemas/main_workflow_schema.json | Adds create-check-run.target to the schema. |
pkg/parser/schema_safe_outputs_target_test.go | Verifies configurations using the property pass validation. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
| }, | ||
| "target": { | ||
| "type": "string", | ||
| "description": "Target pull request for check run attachment: 'triggering' (default), '*' (any PR), or explicit PR number" |
gh-aw-bot
commented
Aug 16, 2026
@copilot PR sous-chef triage for #53113.
Run: https://github.com/github/gh-aw/actions/runs/31948478139
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Implemented the conformance check in 4f1327b. It compares directly declared YAML fields on registered safe-output handler configs with their schema properties and now reports existing schema drift, while covering |
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
🎉 This pull request is included in a new release. Release: |
The Go compiler parses a
targetfield onsafe-outputs.create-check-runand the safe-outputs reference documents all four targeting modes, but the frontmatter JSON schema never declared the property while settingadditionalProperties: false. Any workflow copying the documented example fails to compile, with a suggestion list pointing at unrelated keys.Changes
pkg/parser/schemas/main_workflow_schema.json— added thetargetstring property toproperties.safe-outputs.properties.create-check-run, matching the shape used by the ~27 other safe outputs that already declare it.pkg/parser/schema_safe_outputs_target_test.go— added acreate-check-run with targetcase to the existingTestMainWorkflowSchema_SafeOutputsTargetPropertiesregression table.The reproduction workflow now compiles, and the generated lock file gains the
pull-requests: readpermission the docs describe as auto-added whentargetis configured — previously unreachable.Not addressed
The issue also proposes extending
scripts/check-safe-outputs-conformance.shto assert that everyyaml:tag on a safe-output config struct has a matching schema property, which would catch this class of drift rather than each instance. That is a broader change and is left as a follow-up so this fix stays narrow.