Uh oh!
There was an error while loading. Please reload this page.
Update approve-workflow-run safe output description - #53115
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilotcreated this pull request from a session on behalf of pelikhanAugust 16, 2026 12:47 View session
pelikhan
marked this pull request as ready for review
August 16, 2026 12:51
Contributor
There was a problem hiding this comment.
Pull request overview
Broadens approve-workflow-run documentation beyond fork PRs to all eligible PR workflow runs requiring approval, including Copilot-created PRs.
Changes:
- Updates reference documentation and examples.
- Aligns schemas, tool metadata, validation text, and configuration comments.
- Retains existing approval eligibility and security constraints.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/safe_outputs_validation.go | Broadens validation error wording. |
pkg/workflow/safe_outputs_config_types.go | Updates configuration comment. |
pkg/workflow/js/safe_outputs_tools.json | Updates MCP tool description. |
pkg/workflow/approve_workflow_run.go | Updates configuration type documentation. |
pkg/parser/schemas/main_workflow_schema.json | Broadens schema descriptions. |
docs/src/content/docs/specs/safe-outputs-specification.md | Updates specification terminology. |
docs/src/content/docs/reference/safe-outputs.md | Updates summary table wording. |
docs/src/content/docs/reference/safe-outputs-pull-requests.md | Documents broader approval scenarios. |
actions/setup/js/types/safe-outputs-config.d.ts | Updates TypeScript configuration documentation. |
actions/setup/js/safe_outputs_tools.json | Updates setup-action tool metadata. |
.github/aw/safe-outputs-automation.md | Aligns automation reference and token comments. |
Review details
- Files reviewed: 10/11 changed files
- Comments generated: 2
- Review effort level: Balanced
| { | ||
| "type": "object", | ||
| "description": "Configuration for approving workflow runs that are awaiting approval for a fork pull request.", | ||
| "description": "Configuration for approving workflow runs that are awaiting required approval.", |
| return errors.New( | ||
| "safe-outputs.approve-workflow-run: requires an external github-token or github-app because github.token cannot approve workflow runs for fork pull requests.\n\n" + | ||
| "safe-outputs.approve-workflow-run: requires an external github-token or github-app because github.token cannot approve workflow runs requiring approval.\n\n" + |
github-actionsBot
added a commit
that referenced
this pull request
Aug 17, 2026
Weekly Safe Outputs specification review found that the approve_workflow_run safe output type (added in v1.28.4, PR #52541, refined in #53115) had no corresponding conformance checks in scripts/check-safe-outputs-conformance.sh. Adds TYPE-013 validating: run_id positive-integer validation, staged preview support, pull_request/waiting eligibility checks, allowed- workflows matching with yml/yaml normalization, triggering/allowed pull request authorization, pull_request_target and fork rejection, protected-file checks, explicit external credential requirement, and Abort classification for warn-mode threat detection (spec Section 7.3). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
approve-workflow-runwas described as fork-PR-specific, but it applies to any pull request workflow run requiring approval, including Copilot-created PRs.Reference docs
"action required"/ required-approval workflow runs.Schema and tool metadata
Config comments and validation text