Uh oh!
There was an error while loading. Please reload this page.
Migrate 30 more agentic workflows to the gh-aw-detection feature - #53162
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
✅ Ponytail Reviewer completed successfully! Lean already. Ship. PR is a mechanical, repeated 2-line frontmatter flag addition across 30 workflows; lock.yml files are generated. No over-engineering to flag.
|
✅ PR Code Quality Reviewer completed the code quality review.
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100).
|
Uh oh!
There was an error while loading. Please reload this page.
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. Test Quality Sentinel skipped.
|
Comment MemoryNote This comment is managed by comment memory.It stores persistent context for this thread in the code block at the top of this comment.
|
There was a problem hiding this comment.
Request changes
The external threat-detection rollout removes explicit summary/log publication from these generated workflows, and this diff does not prove the replacement path is always preserved.
Blocking theme
Across the migrated workflows, the generated YAML deletes both the Echo detection step summary step and the Upload threat detection log artifact, while the new artifact stanza in the diff only names detection_result.json. That is a debuggability regression unless the external detector/conclusion path is guaranteed to persist the human-readable summary as part of the uploaded artifact, and this PR does not show or test that guarantee.
Please either keep an explicit summary publication path in the generated workflow or add coverage that proves the migrated artifact always includes the step summary operators need to diagnose warnings and failures.
🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 16.8 AIC · ⌖ 6.3 AIC · ⊞ 6.9K
Comment /review to run again
Comments that could not be inline-anchored
.github/workflows/copilot-centralization-drilldown.lock.yml:174
This rollout drops the only visible publication path for the detection step summary: the old flow echoed /tmp/gh-aw/step-summary.md into the job log and uploaded detection.log, but the new flow uploads only detection_result.json, so if threat-detect or conclude_threat_detection.sh does not persist the summary itself, operators lose the debugging context needed to understand warnings/failures.
<details><summary>💡 Why this blocks the migration</summary>
The PR description says the ne…
There was a problem hiding this comment.
All 30 workflows correctly add features: gh-aw-detection: true and their lock files are consistently recompiled. The migration from the inline detection path to the external AWF binary detector is uniform across all changed files. No issues found.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 20.3 AIC · ⌖ 7.01 AIC · ⊞ 5.6K
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /codebase-design — this is a large, mechanical migration of 30 workflows to the external gh-aw-detection engine. The diff is truncated at 3000 lines (~12 of 30 workflows visible), but the visible portion is highly consistent.
📋 Key Themes & Highlights
Positive Highlights
- ✅ All visible
.mdfiles consistently addfeatures:\n gh-aw-detection: true - ✅ All visible lock files consistently add
GH_AW_INFO_FEATURESandGH_AW_DETECTION_SKIP_PROMPT_SUMMARY: "true" - ✅ Step ordering is consistent: "Install AWF binary" moves before ripgrep/copilot-cli, then "Install threat-detect binary" replaces the old inline node-based detection path
- ✅ PR selection criteria are clearly documented (no
source:frontmatter, hassafe-outputs, nothreat-detection: false) - ✅ Lock files are compiler-generated — no manual edits
Notes
- The diff is truncated at 3000 lines, so only ~12/30 workflows are fully visible. Based on the consistent pattern across all visible files, the remaining 18 workflows are assumed correct.
GH_AW_DETECTION_SKIP_PROMPT_SUMMARY: "true"is present in all visible detection jobs — good, this aligns with the note thatdetection.logis no longer uploaded on this path.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 28 AIC · ⌖ 8.42 AIC · ⊞ 7.7K
Comment /matt to run again
There was a problem hiding this comment.
Pull request overview
Migrates 30 workflows from inline threat detection to the external gh-aw-detection engine.
Changes:
- Enables
features.gh-aw-detectionin 30 workflow definitions. - Regenerates corresponding lock files for external detector execution and structured result artifacts.
- The PR description should be corrected: the detection artifact contains only
detection_result.json.
Show a summary per file
| File | Description |
|---|---|
copilot-centralization-drilldown.md | Enables external detection. |
copilot-centralization-drilldown.lock.yml | Recompiles detection job. |
copilot-centralization-optimizer.md | Enables external detection. |
copilot-centralization-optimizer.lock.yml | Recompiles detection job. |
daily-arxiv-researcher.md | Enables external detection. |
daily-arxiv-researcher.lock.yml | Recompiles detection job. |
daily-code-debt-aider.md | Enables external detection. |
daily-code-debt-aider.lock.yml | Recompiles detection job. |
daily-go-test-parallelizer.md | Enables external detection. |
daily-go-test-parallelizer.lock.yml | Recompiles detection job. |
daily-go-test-stubs-aider.md | Enables external detection. |
daily-go-test-stubs-aider.lock.yml | Recompiles detection job. |
daily-pr-review-cursor.md | Enables external detection. |
daily-pr-review-cursor.lock.yml | Recompiles detection job. |
daily-safe-output-integrator.md | Enables external detection. |
daily-safe-output-integrator.lock.yml | Recompiles detection job. |
daily-safe-output-optimizer.md | Enables external detection. |
daily-safe-output-optimizer.lock.yml | Recompiles detection job. |
daily-safe-outputs-conformance.md | Enables external detection. |
daily-safe-outputs-conformance.lock.yml | Recompiles detection job. |
daily-safeoutputs-git-simulator.md | Enables external detection. |
daily-safeoutputs-git-simulator.lock.yml | Recompiles detection job. |
daily-security-observability.md | Enables external detection. |
daily-security-observability.lock.yml | Recompiles detection job. |
daily-security-red-team.md | Enables external detection. |
daily-security-red-team.lock.yml | Recompiles detection job. |
daily-semgrep-scan.md | Enables external detection. |
daily-semgrep-scan.lock.yml | Recompiles detection job. |
daily-skill-optimizer.md | Enables external detection. |
daily-skill-optimizer.lock.yml | Recompiles detection job. |
daily-spdd-spec-planner.md | Enables external detection. |
daily-spdd-spec-planner.lock.yml | Recompiles detection job. |
daily-spec-coverage-kiro.md | Enables external detection. |
daily-spec-coverage-kiro.lock.yml | Recompiles detection job. |
daily-spending-forecast.md | Enables external detection. |
daily-spending-forecast.lock.yml | Recompiles detection job. |
daily-squid-image-scan.md | Enables external detection. |
daily-squid-image-scan.lock.yml | Recompiles detection job. |
daily-syntax-error-quality.md | Enables external detection. |
daily-syntax-error-quality.lock.yml | Recompiles detection job. |
daily-vulnhunter-scan.md | Enables external detection. |
daily-vulnhunter-scan.lock.yml | Recompiles detection job. |
daily-windows-terminal-integration-builder.md | Enables external detection. |
daily-windows-terminal-integration-builder.lock.yml | Recompiles detection job. |
daily-workflow-updater.md | Enables external detection. |
daily-workflow-updater.lock.yml | Recompiles detection job. |
daily-yamllint-fixer.md | Enables external detection. |
daily-yamllint-fixer.lock.yml | Recompiles detection job. |
dataflow-pr-discussion-dataset.md | Enables external detection. |
dataflow-pr-discussion-dataset.lock.yml | Recompiles detection job. |
deepsec-security-scan.md | Enables external detection. |
deepsec-security-scan.lock.yml | Recompiles detection job. |
delight.md | Enables external detection. |
delight.lock.yml | Recompiles detection job. |
dependabot-burner.md | Enables external detection. |
dependabot-burner.lock.yml | Recompiles detection job. |
dependabot-go-checker.md | Enables external detection. |
dependabot-go-checker.lock.yml | Recompiles detection job. |
dev-hawk.md | Enables external detection. |
dev-hawk.lock.yml | Recompiles detection job. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 60/60 changed files
- Comments generated: 1
- Review effort level: Balanced
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| name: detection | ||
| path: /tmp/gh-aw/threat-detection/detection_result.json |
🎉 This pull request is included in a new release. Release: |
Continues the rollout of the external threat-detection engine by enabling
features: gh-aw-detection: trueon 30 additional workflows that were still running the inline detection path.Selection criteria
Candidates were
.github/workflows/*.mdfiles that:gh-aw-detectionsafe-outputs:(so threat detection actually runs)threat-detection: falsesource:frontmatter entry)Changes
Frontmatter (30 files) — added the feature flag:
Recompiled lock files (30 files) — regenerated
.lock.ymlso the detection job uses the external detector binary instead of the inline engine. Note that on this pathdetection.logis no longer uploaded; thedetectionartifact carriesdetection_result.json+step-summary.md.Migrated workflows
copilot-centralization-drilldown,copilot-centralization-optimizer,daily-arxiv-researcher,daily-code-debt-aider,daily-go-test-parallelizer,daily-go-test-stubs-aider,daily-pr-review-cursor,daily-safe-output-integrator,daily-safe-output-optimizer,daily-safe-outputs-conformance,daily-safeoutputs-git-simulator,daily-security-observability,daily-security-red-team,daily-semgrep-scan,daily-skill-optimizer,daily-spdd-spec-planner,daily-spec-coverage-kiro,daily-spending-forecast,daily-squid-image-scan,daily-syntax-error-quality,daily-vulnhunter-scan,daily-windows-terminal-integration-builder,daily-workflow-updater,daily-yamllint-fixer,dataflow-pr-discussion-dataset,deepsec-security-scan,delight,dependabot-burner,dependabot-go-checker,dev-hawk