Skip to content

Handle bare Design Decision Gate workflow dispatch - #53202

Merged
pelikhan merged 2 commits into
mainfrom
copilot/deep-report-fix-design-decision-gate
Aug 16, 2026
Merged

Handle bare Design Decision Gate workflow dispatch#53202
pelikhan merged 2 commits into
mainfrom
copilot/deep-report-fix-design-decision-gate

Conversation

CopilotAI commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Bare workflow_dispatch runs for Design Decision Gate could fail before the agent started because pr_number is optional in the trigger schema but required by the prefetch shell step. This made manual dispatches without PR context fail as gate errors.

  • Workflow dispatch handling

    • Replaces the hard failure with a graceful skip path for bare dispatches.
    • Writes minimal prefetch artifacts so downstream steps have consistent files.
  • Agent stop condition

    • Adds an explicit skip_reason path so the agent emits noop and stops instead of attempting PR analysis.
  • Generated workflow

    • Recompiled design-decision-gate.lock.yml from the updated markdown source.
{
"pr_number": null,
"file_count": 0,
"requires_adr_by_default_volume": false,
"skip_reason": "workflow_dispatch did not include inputs.pr_number"
}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for working on fixing the Design Decision Gate hard-fail issue (#53174)! 🚀

This PR is currently in draft status with 0 file changes. Here's what we're tracking to get it ready for review:

To completion:

  • Implement the fix — Update design-decision-gate.md and trigger a recompile to regenerate design-decision-gate.lock.yml to make pr_number genuinely optional (graceful skip) or mark it required: true in the schema.
  • Add tests — Include workflow validation or integration tests that verify the Design Decision Gate no longer hard-fails when triggered via bare workflow_dispatch without a pr_number.
  • Complete the checklist — Work through the remaining tasks in the PR description to validate the fix and confirm no regressions.

The issue is well-documented in #53174 — this should resolve the recurring workflow-dispatch failures. Once changes land, the diff will be reviewed.

Keep the draft status until the checklist is complete!

Generated by ✅ Contribution Check · auto · 47.7 AIC · ⌖ 3.22 AIC · ⊞ 9.1K ·

CopilotAI changed the title [WIP] Fix Design Decision Gate hard-fail on workflow_dispatch triggerHandle bare Design Decision Gate workflow dispatchAug 16, 2026
CopilotAI requested a review from pelikhanAugust 16, 2026 21:04
@pelikhan
pelikhan marked this pull request as ready for review August 16, 2026 21:49
CopilotAI balanced review requested due to automatic review settings August 16, 2026 21:49
@pelikhan
pelikhan merged commit aa027bd into mainAug 16, 2026
3 checks passed
@pelikhan
pelikhan deleted the copilot/deep-report-fix-design-decision-gate branch August 16, 2026 21:49

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Handles missing PR context during bare Design Decision Gate dispatches.

Changes:

  • Generates minimal prefetch artifacts for skipped dispatches.
  • Instructs the agent to emit noop.
  • Recompiles the generated workflow.
Show a summary per file
FileDescription
.github/workflows/design-decision-gate.mdAdds graceful dispatch handling and skip instructions.
.github/workflows/design-decision-gate.lock.ymlUpdates compiled workflow output.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

@@ -92,8 +92,29 @@ steps:
set -euo pipefail

if [ "$EXPR_GITHUB_EVENT_NAME" = "workflow_dispatch" ] && [ -z "${PR_NUMBER:-}" ]; then
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.87.1

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[deep-report] Fix Design Decision Gate hard-fail on bare workflow_dispatch (pr_number codegen mismatch)

3 participants

@pelikhan