Uh oh!
There was an error while loading. Please reload this page.
Handle bare Design Decision Gate workflow dispatch - #53202
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Thanks for working on fixing the Design Decision Gate hard-fail issue (#53174)! 🚀 This PR is currently in draft status with 0 file changes. Here's what we're tracking to get it ready for review: To completion:
The issue is well-documented in #53174 — this should resolve the recurring workflow-dispatch failures. Once changes land, the diff will be reviewed. Keep the draft status until the checklist is complete!
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull request overview
Handles missing PR context during bare Design Decision Gate dispatches.
Changes:
- Generates minimal prefetch artifacts for skipped dispatches.
- Instructs the agent to emit
noop. - Recompiles the generated workflow.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/design-decision-gate.md | Adds graceful dispatch handling and skip instructions. |
.github/workflows/design-decision-gate.lock.yml | Updates compiled workflow output. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
| @@ -92,8 +92,29 @@ steps: | |||
| set -euo pipefail | |||
| if [ "$EXPR_GITHUB_EVENT_NAME" = "workflow_dispatch" ] && [ -z "${PR_NUMBER:-}" ]; then | |||
🎉 This pull request is included in a new release. Release: |
Bare
workflow_dispatchruns for Design Decision Gate could fail before the agent started becausepr_numberis optional in the trigger schema but required by the prefetch shell step. This made manual dispatches without PR context fail as gate errors.Workflow dispatch handling
Agent stop condition
skip_reasonpath so the agent emitsnoopand stops instead of attempting PR analysis.Generated workflow
design-decision-gate.lock.ymlfrom the updated markdown source.{ "pr_number": null, "file_count": 0, "requires_adr_by_default_volume": false, "skip_reason": "workflow_dispatch did not include inputs.pr_number" }