Fix premature copilot-sdk readiness timeout and unhelpful engine failure context by Copilot · Pull Request #53299 · github/gh-aw

Copilot · 2026-08-17T05:18:03Z

The Daily GitHub Docs SEO Optimizer run failed with an engine failure whose only reported context was The Docker agent cgroup cannot be passed through, so pids.max/pids.current are unavailable. — an unrelated AWF warning. Two separate defects: the copilot-sdk sidecar aborted a server that was still starting, and the failure reporter surfaced infrastructure noise instead of the actual error.

Root cause

From the run's agent-stdio.log:

[copilot-harness] copilot-sdk stderr: Package extraction took 6883ms
[copilot-harness] copilot-sdk stdout: CLI server listening on port 3002
[copilot-harness] copilot-sdk: stopping headless server pid=322
[copilot-harness] unexpected error: copilot-sdk headless server did not become ready on 127.0.0.1:3002 within 5000ms (connect ETIMEDOUT 127.0.0.1:3002)

The Copilot CLI spent ~6.9s extracting its bundle before binding the port; the readiness probe's 5s budget expired first and killed a healthy server.

The failure issue then reported the wrong line because [copilot-harness] … matches AWF_INFRA_LINE_RE and was stripped, while the indented continuation of a preceding [WARN] line did not match and survived as the only "agent output".

Changes

copilot_sdk_sidecar.cjs — COPILOT_SDK_SERVER_STARTUP_TIMEOUT_MS 5s → 60s. The startup Promise.race still rejects immediately on child error/exit, so a genuinely broken server continues to fail fast; the larger budget only affects the slow-start path. Constant is now exported so the budget is asserted in tests.
handle_agent_failure.cjs
- Extract [<copilot|claude|codex>-harness] unexpected error: <message> into errorMessages, so harness terminal failures are reported as Error details rather than falling through to the log tail.
- Drop indented continuation lines that follow an AWF infrastructure line from the fallback tail, so wrapped [WARN]/[INFO] messages are no longer mistaken for agent output.
Tests — three cases in handle_agent_failure.test.cjs covering harness-error extraction, continuation filtering, and the infra-only log path; one in copilot_harness.test.cjs guarding the startup budget.

Replaying the original log through buildEngineFailureContext() now produces:

> **Engine Failure**: The `copilot` engine terminated before producing output.
**Error details:**
- copilot-sdk headless server did not become ready on 127.0.0.1:3002 within 5000ms (connect ETIMEDOUT 127.0.0.1:3002)

Fixes[aw] Daily GitHub Docs SEO Optimizer failed #53298

…failure context Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-08-17T06:28:54Z

PR Triage

Category: bug | Risk: medium | Score: 55/100

Impact: 25/50 (fixes engine timeout/failure context, affects reliability)
Urgency: 20/30 (addresses premature failures blocking runs)
Quality: 10/20

Recommended action: fast_track

Generated by 🔧 PR Triage Agent · auto · 43 AIC · ⌖ 2.45 AIC · ⊞ 8.1K · ◷

Copilot

Pull request overview

Fixes Copilot SDK startup timing and improves engine failure diagnostics.

Changes:

Extends sidecar startup timeout to 60 seconds.
Extracts harness errors and filters wrapped infrastructure noise.
Adds regression tests for both behaviors.

Show a summary per file

File	Description
`actions/setup/js/copilot_sdk_sidecar.cjs`	Extends and exports the startup timeout.
`actions/setup/js/copilot_harness.test.cjs`	Verifies the startup budget.
`actions/setup/js/handle_agent_failure.cjs`	Improves failure-context extraction and filtering.
`actions/setup/js/handle_agent_failure.test.cjs`	Adds failure-reporting regression tests.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Files reviewed: 4/4 changed files
Comments generated: 1
Review effort level: Balanced

+ * These lines carry the actionable root cause even though the harness prefix marks them as
+ * infrastructure output, so they are extracted as engine error details.
+ */
+const HARNESS_UNEXPECTED_ERROR_RE = /^\[(?:copilot|claude|codex)-harness\]\s*unexpected error:\s*(.+)$/;


github-actions · 2026-08-17T11:27:46Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #53299 does not have the 'implementation' label and has 0 new lines of code in business logic directories (4 files changed, none in src/, lib/, pkg/, internal/, app/, core/, domain/, services/, or api/).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-08-17T11:27:47Z

✅ Ponytail Reviewer completed successfully!

Lean already. Ship.

Generated by Ponytail Reviewer for #53299

github-actions · 2026-08-17T11:27:47Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-08-17T11:27:50Z

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-08-17T11:28:02Z

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-08-17T11:31:47Z

Comment Memory

reviewed_at: 2026-08-17T00:00:00Z
review_event: REQUEST_CHANGES
top_themes:
- harness error regex misses timestamped Claude/Codex output
- failure-context fix is incomplete across engines
files_reviewed:
- actions/setup/js/copilot_harness.test.cjs
- actions/setup/js/copilot_sdk_sidecar.cjs
- actions/setup/js/handle_agent_failure.cjs
- actions/setup/js/handle_agent_failure.test.cjs
comment_count: 1

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 15.6 AIC · ⌖ 5.53 AIC · ⊞ 6.9K · ◷
_{Comment /review to run again}

github-actions

Request changes

The failure-context parser still misses terminal harness errors from the timestamped Claude/Codex wrappers, so this is not yet a general fix for the bug class the PR is addressing.

Blocking theme

HARNESS_UNEXPECTED_ERROR_RE only matches [<engine>-harness] unexpected error: ... with no timestamp between the prefix and message.
claude_harness.cjs and codex_harness.cjs log as [claude-harness] <ISO timestamp> unexpected error: ..., so their terminal failures still bypass Error details extraction.
That leaves the reporter falling back to tail parsing and potentially surfacing infrastructure noise again for those engines.

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 15.6 AIC · ⌖ 5.53 AIC · ⊞ 6.9K
_{Comment /review to run again}

github-actions · 2026-08-17T11:31:50Z

+ * These lines carry the actionable root cause even though the harness prefix marks them as
+ * infrastructure output, so they are extracted as engine error details.
+ */
+const HARNESS_UNEXPECTED_ERROR_RE = /^\[(?:copilot|claude|codex)-harness\]\s*unexpected error:\s*(.+)$/;


This regex is too narrow for the actual harness output: claude_harness.cjs and codex_harness.cjs prepend an ISO timestamp after the prefix ([claude-harness] 2026-... unexpected error: ...), so those failures still will not be extracted into Error details and the reporter will fall back to tail noise again.
💡 Fix and rationale
Allow an optional timestamp/token section between the harness prefix and unexpected error: instead of requiring the message to start immediately after ], for example:
constHARNESS_UNEXPECTED_ERROR_RE=/^\[(?:copilot|claude|codex)-harness\](?:\s+\S+)?\s+unexpectederror:\s*(.+)$/;
or, more robustly, capture everything after the prefix until unexpected error:.
Without that, this patch only fixes Copilot while Claude/Codex still misclassify the same terminal harness failures.

github-actions

Review

The PR addresses two real bugs: the 5 s copilot-SDK startup timeout causing false failures during package extraction, and infrastructure "continuation" lines polluting the failure-context tail. Both fixes are correct and well-tested.

Blocking issue: `HARNESS_UNEXPECTED_ERROR_RE` doesn't match claude/codex harness output format

This was already flagged in an open review comment (line 46, handle_agent_failure.cjs) and is the only blocking issue I found.

copilot_harness.cjslog() writes [copilot-harness] <message> (no timestamp), so the regex works there. But claude_harness.cjs and codex_harness.cjs write [claude-harness] <ISO-timestamp> <message> — the regex anchor unexpected error: immediately after \]\s* will never match those lines. The "copilot|claude|codex" alternation in the constant is misleading until the timestamp is accounted for.

Fix: make the timestamp optional in the pattern, e.g.:

constHARNESS_UNEXPECTED_ERROR_RE=/^\[(?:copilot|claude|codex)-harness\](?:\s+[\d:TZ.-]+)?\s*unexpectederror:\s*(.+)$/;

And add a test case using a [claude-harness] 2026-...T...Z unexpected error: ... line to confirm the match.

Non-blocking observations

COPILOT_SDK_SERVER_STARTUP_TIMEOUT_MS export: exporting the constant is a reasonable choice for testability; the test assertion (≥ 30000) correctly guards against future regressions. The 60 s value is generous but justified given real-world ~7 s extraction times and the fast-path rejection on process exit.
Infra continuation heuristic: the leading-whitespace heuristic is simple and effective for the observed log format. An empty line resets previousWasInfra, which is correct (blank lines separate logical blocks).
agentLines filter chain: the refactor to multi-line .filter(...) improves readability without changing semantics.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 23.7 AIC · ⌖ 10 AIC · ⊞ 5.6K

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs and /tdd — commenting on one correctness issue (regex mismatch for harness log format).

📋 Key Themes & Highlights

Key Themes

Regex/format mismatch: HARNESS_UNEXPECTED_ERROR_RE won't match claude-harness or codex-harness lines because their log() functions insert an ISO timestamp between the prefix and the message. Only copilot-harness omits the timestamp. The existing review comment (#3795878652) flags this on line 46 — it should be addressed before merging.
Continuation-line filtering: The new infraContinuationLines scan is correct but only handles one indentation level; multi-level wraps would survive. Acceptable for the current patterns but worth a comment.

Positive Highlights

✅ Root cause properly addressed — timeout increased to 60 s with a clear comment explaining the fast-fail path still applies
✅ COPILOT_SDK_SERVER_STARTUP_TIMEOUT_MS exported and asserted in a test — makes the budget observable and regression-proof
✅ Three well-structured test cases covering harness-error extraction, continuation filtering, and infra-only log; good Arrange/Act/Assert layout
✅ Good progressive filtering approach: extract known error patterns first, fall back to tail only when nothing matched

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 47.3 AIC · ⌖ 8.88 AIC · ⊞ 7.7K
_{Comment /matt to run again}

Done

github-actions · 2026-08-18T22:23:34Z

🎉 This pull request is included in a new release.

Release: v0.87.1

Initial plan
3e3d0da

CopilotAI assigned Copilot and pelikhan Aug 17, 2026

CopilotAI linked an issue Aug 17, 2026 that may be closed by this pull request
[aw] Daily GitHub Docs SEO Optimizer failed #53298
Closed

Copilotstarted work on behalf of pelikhan August 17, 2026 05:18 View session

CopilotAIand others added 2 commits August 17, 2026 05:26

Surface harness terminal errors and filter AWF continuation noise in …
f4a454f
…failure context Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Give the copilot-sdk headless server a realistic startup budget
71a8f41
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Debug workflow failure in Daily GitHub Docs SEO Optimizer~~Fix premature copilot-sdk readiness timeout and unhelpful engine failure contextAug 17, 2026

Copilotfinished work on behalf of pelikhan August 17, 2026 05:29

CopilotAI requested a review from pelikhan August 17, 2026 05:29

github-actionsBot mentioned this pull request Aug 17, 2026
[pr-review] Daily PR Code Quality Review — 31999485709 #53319
Closed

github-actionsBot added pr-action:fast_track pr-agent:copilot-swe-agent pr-priority:high pr-risk:medium pr-type:bug labels Aug 17, 2026

github-actionsBot mentioned this pull request Aug 17, 2026
[PR Triage Report] PR Triage Report — Run 32001256528 #53323
Closed

pelikhan marked this pull request as ready for review August 17, 2026 11:13

CopilotAI balanced review requested due to automatic review settings August 17, 2026 11:13

Copilotstarted reviewing on behalf of pelikhan August 17, 2026 11:13 View session

CopilotAI reviewed Aug 17, 2026
View reviewed changes

github-actionsBot mentioned this pull request Aug 17, 2026
[pr-sous-chef] PR Sous Chef run report #53244
Closed

github-actionsBot requested changes Aug 17, 2026
View reviewed changes

github-actionsBot mentioned this pull request Aug 17, 2026
[aw] No-Op Runs #48838
Open

github-actionsBot previously requested changes Aug 17, 2026
View reviewed changes

pelikhan merged commit 5cb128a into mainAug 17, 2026
65 checks passed

pelikhan deleted the copilot/aw-daily-github-docs-seo-optimizer-fix branch August 17, 2026 11:45

CopilotAI mentioned this pull request Aug 17, 2026
Simplify GitHub access modes #53236
Closed

Uh oh!

Conversation

CopilotAI commented Aug 17, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root cause

Changes

Uh oh!

github-actionsBot commented Aug 17, 2026

PR Triage

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actionsBot commented Aug 17, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Aug 17, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Aug 17, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Aug 17, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Aug 17, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Aug 17, 2026

Comment Memory

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Request changes

Uh oh!

github-actionsBotAug 17, 2026

Choose a reason for hiding this comment

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Review

Blocking issue: HARNESS_UNEXPECTED_ERROR_RE doesn't match claude/codex harness output format

Non-blocking observations

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Uh oh!

Uh oh!

github-actionsBot commented Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CopilotAI commented Aug 17, 2026•
edited
Loading

github-actionsBot commented Aug 17, 2026•
edited
Loading

github-actionsBot commented Aug 17, 2026•
edited
Loading

github-actionsBot commented Aug 17, 2026•
edited
Loading

github-actionsBot commented Aug 17, 2026•
edited
Loading

github-actionsBot commented Aug 17, 2026•
edited
Loading

Blocking issue: `HARNESS_UNEXPECTED_ERROR_RE` doesn't match claude/codex harness output format