Skip to content

Constrain go-logger candidate selection to prevent agent timeout - #53302

Merged
pelikhan merged 2 commits into
mainfrom
copilot/aw-fix-go-logger-enhancement
Aug 17, 2026
Merged

Constrain go-logger candidate selection to prevent agent timeout#53302
pelikhan merged 2 commits into
mainfrom
copilot/aw-fix-go-logger-enhancement

Conversation

CopilotAI commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

The Go Logger Enhancement workflow was failing because the Claude run drifted into broad exploratory reads, exhausted tokens, and hit the 15-minute engine timeout before making actionable edits. This change tightens the workflow prompt to keep selection deterministic and bounded.

  • Root-cause containment in workflow instructions

    • Added a new guidance block in .github/workflows/go-logger.md (1.5. Keep Selection Deterministic and Bounded) to explicitly prevent unbounded discovery behavior.
  • Deterministic file-selection contract

    • Disallow sub-agent use for discovery/complexity scoring.
    • Disallow broad pkg/ scanning once preflight manifest data exists.
    • Require selection strictly from manifest.json (files_needing_logger).
    • If candidate count exceeds limit, take the first 5 entries and proceed to edits.
  • Compiled workflow update

    • Regenerated .github/workflows/go-logger.lock.yml from the markdown source so runtime behavior matches the updated prompt.
### 1.5. Keep Selection Deterministic and Bounded- Do **not** launch sub-agents for file discovery or complexity scoring.
- Do **not** scan `pkg/` broadly once `manifest.json` is available.
- Select files only from `files_needing_logger` in `manifest.json`.
- If more than 5 files are listed, take the first 5 entries and continue directly to edits.

CopilotAI linked an issue Aug 17, 2026 that may be closed by this pull request
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI changed the title [WIP] Fix Go Logger enhancement workflow failureConstrain go-logger candidate selection to prevent agent timeoutAug 17, 2026
CopilotAI requested a review from pelikhanAugust 17, 2026 05:33
@github-actions

Copy link
Copy Markdown
Contributor

PR Triage

Category: bug | Risk: low | Score: 35/100

  • Impact: 15/50 | Urgency: 10/30 | Quality: 10/20

Recommended action: batch_review (grouped with #53301, #53300 as small workflow/agent fixes)

Generated by 🔧 PR Triage Agent · auto · 43 AIC · ⌖ 2.45 AIC · ⊞ 8.1K ·

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds bounded candidate-selection guidance to prevent Go Logger Enhancement workflow timeouts.

Changes:

  • Restricts discovery to the manifest and at most five files.
  • Regenerates the workflow lock metadata.
Show a summary per file
FileDescription
.github/workflows/go-logger.mdAdds deterministic selection instructions.
.github/workflows/go-logger.lock.ymlUpdates the compiled body hash.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

- Do **not** launch sub-agents for file discovery or complexity scoring.
- Do **not** scan `pkg/` broadly once `manifest.json` is available.
- Select files only from `files_needing_logger` in `manifest.json`.
- If more than 5 files are listed, take the first 5 entries and continue directly to edits.
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.87.1

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Go Logger Enhancement failed

3 participants

@pelikhan