Simplify TestIsActivationJobNeeded to match unconditional source behavior

[Copilot]

isActivationJobNeeded() takes no parameters and unconditionally returns true (compiler_jobs.go:23-31), but its test had four subtests that each constructed a WorkflowData, discarded it via var _ = data inside an immediately-invoked closure, and asserted the same constant. The subtests were functionally identical and implied a dependency on WorkflowData that does not exist.

Changes

• Collapsed the four redundant subtests into a single assertion.
• Removed the no-op WorkflowData construction and var _ = data closures.
• Switched from if !cond { t.Errorf(...) } to assert.True, consistent with compiler_jobs_test.go in the same package.
• Added a doc comment tying the expectation to the behavior documented in the source.

Before:

t.Run("if_condition_present", func(t*testing.T) {
data:=&WorkflowData{If: "if: github.ref == 'refs/heads/main'"}
if!func() bool {
var_=datareturncompiler.isActivationJobNeeded()
}() {
t.Errorf("Expected isActivationJobNeeded to be true when If condition is specified")
}
})

After:

// TestIsActivationJobNeeded verifies that isActivationJobNeeded always returns true.// As documented in compiler_jobs.go, the activation job is unconditionally required to// perform the timestamp check, and it also handles command configuration, text output,// runtime If conditions, and consolidated permission checks.funcTestIsActivationJobNeeded(t*testing.T) {
compiler:=NewCompiler()
assert.True(t, compiler.isActivationJobNeeded(), "activation job is always needed")
}

referencesCustomJobOutputs and jobDependsOnPreActivation were left alone — already covered in compiler_jobs_test.go and custom_job_condition_test.go, with no duplication drift observed.

• Fixes[testify-expert] Improve Test Quality: pkg/workflow/is_task_job_needed_test.go #53445

[Copilot]

Pull request overview

Simplifies activation-job testing to reflect its unconditional behavior.

Changes:

• Replaces four redundant subtests with one assert.True.
• Removes misleading unused WorkflowData setup.
• Documents why the activation job is always required.

Show a summary per file

File	Description
pkg/workflow/is_task_job_needed_test.go	Streamlines and clarifies the activation-job test.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.87.1