Uh oh!
There was an error while loading. Please reload this page.
Prevent recurring PR Sous Chef safe-output failures - #53676
Merged
Conversation
Contributor
PR TriageCategory: chore (WIP) | Risk: low | Priority: low (score 20)
Recommended action: defer — recheck once agent finishes and diff is populated
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Investigate root cause of PR Sous Chef safe_outputs job failuresPrevent recurring PR Sous Chef safe-output failuresAug 18, 2026
| body: true | ||
| operation: append | ||
| update-branch: true | ||
| update-branch.stacks: true |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
commented
Aug 18, 2026
Collaborator
@copilot resolve the merge conflicts on this branch. |
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents PR Sous Chef safe-output failures by handling stacked-PR 403 responses and constraining review queries.
Changes:
- Treats canonical stacked-PR 403/422 errors as non-fatal.
- Renames the fallback option to
sync-stack. - Scopes PR Sous Chef queries to
github/gh-aw.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/update_pull_request.go | Parses sync-stack. |
pkg/workflow/update_pull_request_test.go | Tests configuration parsing. |
pkg/parser/schemas/main_workflow_schema.json | Updates the frontmatter schema. |
pkg/cli/pr_sous_chef_workflow_contract_test.go | Adds workflow contract assertions. |
docs/src/content/docs/reference/frontmatter-full.md | Updates reference documentation. |
actions/setup/js/update_pull_request.test.cjs | Adds 403 regression coverage. |
actions/setup/js/update_pull_request.cjs | Recognizes stacked-PR 403 responses. |
.github/workflows/pr-sous-chef.md | Enables fallback and scopes queries. |
.github/workflows/pr-sous-chef.lock.yml | Refreshes compiled metadata. |
.github/aw/safe-outputs-management.md | Documents sync-stack. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 10/10 changed files
- Comments generated: 2
- Review effort level: Balanced
| const status = getErrorStatus(error); | ||
| const message = getErrorMessage(error).toLowerCase(); | ||
| return status === 422 && message.includes("updating a stacked pr's branch via this endpoint is not supported"); | ||
| return (status === 403 || status === 422) && message.includes("updating a stacked pr's branch via this endpoint is not supported"); |
Comment on lines
+1167
to
+1169
| expect(result.success).toBe(true); | ||
| expect(mockGithub.rest.pulls.update).toHaveBeenCalled(); | ||
| expect(mockCore.warning).toHaveBeenCalledWith(expect.stringContaining("branch from base (non-fatal)")); |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
ContributorAuthor
…ation Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Sous Chef repeatedly failed after successful agent runs because GitHub reports unsupported stacked-PR branch updates as either HTTP 403 or 422. Unscoped review queries also produced foreign thread IDs rejected by safe-output safeguards.
Stacked PR handling
Repository scoping
github/gh-awreview threads and reviews.Regression coverage