[test-parallel] test: add t.Parallel() to safe pkg/cli tests (batch 2)

[github-actions]

placeholder-test> Generated by PR Description Updater for #54024 · auto · 34.9 AIC · ⌖ 4.17 AIC · ⊞ 7.6K · ◷

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

[github-actions]

❌ Ponytail Reviewer failed. Please review the logs for details.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by Ponytail Reviewer for #54024

[github-actions]

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #54024 does not have the implementation label and has only 31 new lines of code in business logic directories (threshold: 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

[github-actions]

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

[github-actions]

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

[github-actions]

Skills-Based Review 🧠

Applied /tdd — approving. The parallel additions are mechanical, correct, and race-verified.

📋 Review Summary

Positive Highlights

• ✅ All parent tests and their subtests consistently marked t.Parallel() — no orphaned outer-parallel-without-inner or vice versa
• ✅ Loop-variable capture is safe under Go 1.22+ semantics (no tt := tt rebinding needed)
• ✅ Race detector run (-race) confirmed clean — the strongest signal that no shared state was missed
• ✅ Pre-existing test failures correctly attributed to sandbox environment, not the parallel additions
• ✅ t.TempDir() used in importpath_test.go and grant_test.go — automatically cleaned up and safe under parallelism

No actionable issues found.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 18.4 AIC · ⌖ 9.81 AIC · ⊞ 7.8K
_{Comment /matt to run again}

[github-actions]

Comment Memory

reviewed_at: 2026-08-19T00:00:00Z
review_event: COMMENT
top_themes:
- no actionable issues found
- parallelized tests appear isolated and safe
files_reviewed:
- pkg/cli/frontmatter_formatting_test.go
- pkg/cli/grant_test.go
- pkg/cli/help_text_test.go
- pkg/cli/helpers_json_test.go
- pkg/cli/importpath_test.go
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 3.47 AIC · ⌖ 7.87 AIC · ⊞ 7K · ◷
_{Comment /review to run again}

[github-actions]

Verdict

Non-blocking change: this batch only adds t.Parallel() to tests that appear isolated, and I did not find a changed-line correctness or maintainability issue worth blocking.

Highlights

• The added parallelization is limited to tests using local data or t.TempDir(), which matches the PR description.
• I did not see newly introduced shared mutable state, global environment mutation, or cross-test filesystem coupling in the changed lines.
• No duplicate review comments were present, and the background sub-agent did not return usable findings.

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 3.47 AIC · ⌖ 7.87 AIC · ⊞ 7K
_{Comment /review to run again}

[Copilot]

Pull request overview

Adds safe parallel execution to independent pkg/cli Go tests, reducing suite runtime without changing production behavior.

Changes:

• Marks eligible top-level tests as parallel.
• Parallelizes independent table-driven subtests.
• Retains isolated temporary directories and local test data.

Show a summary per file

File	Description
pkg/cli/frontmatter_formatting_test.go	Parallelizes pure formatting tests.
pkg/cli/grant_test.go	Parallelizes independent grant tests.
pkg/cli/help_text_test.go	Parallelizes constant validation.
pkg/cli/helpers_json_test.go	Parallelizes JSON helper tests.
pkg/cli/importpath_test.go	Parallelizes path-resolution tests using isolated directories.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 5/5 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

LGTM. All t.Parallel() additions are safe: shared state (originalContent) is read-only and defined before the parallel call, and no subtests capture loop variables without copying. Clean batch.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 17.6 AIC · ⌖ 8.79 AIC · ⊞ 5.7K

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.87.2