Uh oh!
There was an error while loading. Please reload this page.
Add formal conformance-registry invariants for AWF config fixture index - #54041
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Hey there 👋 — great work on formalizing the conformance-registry invariants! This PR aligns perfectly with the project's focus on maintainable AWF specifications. Your approach is solid:
This PR is ready for review and looks great to merge!
|
PR TriageCategory: docs · Risk: low · Score: 27/100 (impact 10 + urgency 5 + quality 12) Draft formal spec addition; low urgency, single-file, needs CI. Automated triage — see run report for full details.
|
There was a problem hiding this comment.
Pull request overview
Adds formal tests intended to validate AWF conformance-registry invariants and edge cases.
Changes:
- Models registry IDs, rows, routing, and cross-references.
- Tests ID formatting, uniqueness, monotonicity, and rollover behavior.
- Adds safeguard-series and missing-file edge cases.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/awf_config_conformance_registry_formal_test.go | Adds the registry invariant model and tests. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Balanced
| func formalConformanceRegistryBaselineRows() []formalConformanceRegistryRow { | ||
| return []formalConformanceRegistryRow{ |
| func TestFormalConformanceRegistry_P8_SpecCrossReferenceRequired(t *testing.T) { | ||
| specIDs := map[string]struct{}{ | ||
| "T-DR-010": {}, | ||
| "T-DR-SAFE-004": {}, | ||
| } |
gh-aw-bot
commented
Aug 19, 2026
@copilot This PR still has unresolved reviewer concerns before it is ready for a maintainer handoff.
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Addressed in f2513c4: the formal suite now parses the fixture index, validates its documented test-file mappings, and verifies every registry ID against the parent specification's actual content. Added the missing plain-series specification references and completed local scoped validation. |
🎉 This pull request is included in a new release. Release: |
This PR formalizes the conformance-registry process defined in
specs/awf-config-sources-compliance/README.md, focusing on howT-DR-*/T-DR-SAFE-*IDs and rows are authored and validated (not re-testing existing DriftRecord schema predicates). It adds a dedicated formal suite for registry invariants and edge conditions documented in the spec’s meta-process.Formal registry model coverage
pkg/workflow/awf_config_conformance_registry_formal_test.gowith focused helpers and tests for:T-DR-011after baselineT-DR-001..010)T-DR-001)§-anchored)pkg/workflow/*_test.goEdge-case hardening
T-DR-1000) without truncation.T-DR-SAFE-*IDs from being interpreted as plainT-DR-*IDs.Representative invariant check