Skip to content

Make failure investigator log capture fault-aware - #54098

Merged
pelikhan merged 2 commits into
mainfrom
copilot/fix-copilot-cli-startup-crash
Aug 20, 2026
Merged

Make failure investigator log capture fault-aware#54098
pelikhan merged 2 commits into
mainfrom
copilot/fix-copilot-cli-startup-crash

Conversation

CopilotAI commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Failure Investigator was treating backend cleanup markers as real failures, masking pre-network Copilot CLI startup errors and reporting false-negative captures.

  • Fault detection
    • Replace broad ##[error]/generic matching with fault and non-zero-exit markers.
    • Search backward through full job logs for the most recent meaningful fault.
  • Capture validation
    • Validate markers within the captured window itself.
    • Set capture_likely_missed_fault when the window lacks fault evidence.
  • Workflow parity
    • Regenerate the compiled workflow lock file.
    • Add regression assertions for the updated heuristic.
has_fault_marker=any(
FAULT_MARKER.search(line) forlineincaptured_lines
)
capture_likely_missed_fault=nothas_fault_marker

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI changed the title [WIP] Fix Copilot CLI startup crash leading to capture blindnessMake failure investigator log capture fault-awareAug 20, 2026
CopilotAI requested a review from pelikhanAugust 20, 2026 00:44
@pelikhan
pelikhan marked this pull request as ready for review August 20, 2026 00:57
CopilotAI balanced review requested due to automatic review settings August 20, 2026 00:57
@pelikhan
pelikhan merged commit 589b066 into mainAug 20, 2026
@pelikhan
pelikhan deleted the copilot/fix-copilot-cli-startup-crash branch August 20, 2026 00:57

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates failure-investigator log capture to locate meaningful faults and validate captured windows.

Changes:

  • Introduces fault-marker-based backward log searching.
  • Updates capture validation and regression assertions.
  • Regenerates the compiled workflow.
Show a summary per file
FileDescription
.github/workflows/aw-failure-investigator.mdUpdates fault detection and capture validation.
.github/workflows/aw-failure-investigator.lock.ymlRegenerates the compiled workflow.
pkg/cli/aw_failure_investigator_workflow_test.goUpdates heuristic assertions.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment on lines +93 to +94
r"\b(?:error|panic|exception|traceback|fatal|abort|segfault|coredump)\b|"
r"(?:process|command).*(?:failed|exit code)|(?:exit code|non-zero exit)",
Comment on lines +21 to +24
`FAULT_MARKER = re.compile(`,
`def capture_error_window(log_text):`,
`"capture_likely_missed_fault": not has_error_marker`,
`has_fault_marker = any(FAULT_MARKER.search(line) for line in captured_lines)`,
`"capture_likely_missed_fault": not has_fault_marker`,
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants

@pelikhan