Uh oh!
There was an error while loading. Please reload this page.
Make failure investigator log capture fault-aware - #54098
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Fix Copilot CLI startup crash leading to capture blindnessMake failure investigator log capture fault-awareAug 20, 2026
pelikhan
marked this pull request as ready for review
August 20, 2026 00:57
Contributor
There was a problem hiding this comment.
Pull request overview
Updates failure-investigator log capture to locate meaningful faults and validate captured windows.
Changes:
- Introduces fault-marker-based backward log searching.
- Updates capture validation and regression assertions.
- Regenerates the compiled workflow.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/aw-failure-investigator.md | Updates fault detection and capture validation. |
.github/workflows/aw-failure-investigator.lock.yml | Regenerates the compiled workflow. |
pkg/cli/aw_failure_investigator_workflow_test.go | Updates heuristic assertions. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
Comment on lines
+93
to
+94
| r"\b(?:error|panic|exception|traceback|fatal|abort|segfault|coredump)\b|" | ||
| r"(?:process|command).*(?:failed|exit code)|(?:exit code|non-zero exit)", |
Comment on lines
+21
to
+24
| `FAULT_MARKER = re.compile(`, | ||
| `def capture_error_window(log_text):`, | ||
| `"capture_likely_missed_fault": not has_error_marker`, | ||
| `has_fault_marker = any(FAULT_MARKER.search(line) for line in captured_lines)`, | ||
| `"capture_likely_missed_fault": not has_fault_marker`, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure Investigator was treating backend cleanup markers as real failures, masking pre-network Copilot CLI startup errors and reporting false-negative captures.
##[error]/generic matching with fault and non-zero-exit markers.capture_likely_missed_faultwhen the window lacks fault evidence.