Uh oh!
There was an error while loading. Please reload this page.
Skip GHES auto-detection during CI initialization - #54112
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Nice work,
|
There was a problem hiding this comment.
Pull request overview
Prevents GHES auto-detection from changing repository configuration during CI initialization.
Changes:
- Skips GHES configuration when CI is detected.
- Adds CI and non-CI regression coverage.
- Removes the explicit GHES override and synchronizes the dispatcher skill list.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/init.go | Adds the CI guard for GHES configuration. |
pkg/cli/init_test.go | Tests CI skipping and non-CI detection. |
.github/workflows/aw.json | Removes the forced ghes: false setting. |
.github/skills/agentic-workflows/SKILL.md | Adds jobs.md to the generated file list. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
| if _, err := os.Stat(filepath.Join(tempDir, ".github", "workflows", "aw.json")); !os.IsNotExist(err) { | ||
| t.Fatal("ensureGHESRepoConfig should not create aw.json in CI") |
🎉 This pull request is included in a new release. Release: |
GHES detection during
initcan be misled bygh-proxyenvironment settings and must not run in CI. The repository should also rely on automatic detection rather than forcingghes: false.Initialization guard
Regression coverage
aw.json.Repository configuration
ghes: falseentry from.github/workflows/aw.json.