[test-parallel] Add t.Parallel() to safe Go tests in pkg/cli (daily batch)

[github-actions]

Daily Go Test Parallelizer

Analyzed a batch of 25 pkg/cli test files (round-robin, starting right after pkg/cli/logs_empty_runs_test.go per cache state), using per-file parallel-safety-checker sub-agents.

Changes

Added t.Parallel() to the start of top-level test functions confirmed safe (no t.Setenv/os.Setenv/os.Chdir, no shared mutable globals, no fixed ports/paths outside per-test temp dirs, no ordering dependencies):

• logs_engine_filter_test.go — TestMatchEngineFilter, TestMatchRuntimeFilter
• logs_extract_zip_test.go — all 6 top-level tests
• logs_firewall_filter_test.go — all 3 top-level tests
• logs_formatting_test.go — TestFormatNumber, TestFormatFileSize
• logs_github_rate_limit_usage_test.go — all 11 top-level tests
• logs_json_test.go — all 17 top-level tests
• logs_mcp_tool_usage_test.go — all 4 top-level tests
• logs_missing_data_test.go — both top-level tests
• logs_missing_tool_test.go — both top-level tests
• logs_noop_test.go — all 4 top-level tests

Table-driven subtests were intentionally left unparallelized where the loop variable is captured without rebinding, or where iterations share a temp file/dir (would require production/test refactor, which is out of scope).

Left unchanged (judged unsafe)

logs_episode_test.go, logs_fallback_integration_test.go, logs_filtering_test.go, logs_firewall_parse_test.go, logs_flatten_test.go, logs_github_api_test.go, logs_json_clean_test.go, logs_json_stderr_order_test.go, logs_mcp_failure_test.go, logs_missing_tool_integration_test.go, logs_orchestrator_filters_test.go, logs_orchestrator_pagination_test.go, logs_orchestrator_test.go — these use t.Setenv, redirect os.Stdout/os.Stderr, mutate shared package-level stubs, bind fixed ports via httptest, or have timing-dependent behavior.

Validation

• go build ./pkg/cli/... — passes
• go test -race ./pkg/cli/... -run '<all modified top-level tests>' — all pass
• go test ./pkg/cli/... full run — only pre-existing, unrelated sandbox failures remain (httptest port binding, TTY color detection), reproduced identically on the unmodified tree

No assertions, production code, or dependencies were changed.

Generated by Daily Go Test Parallelizer · auto · 85.7 AIC · ⌖ 9.04 AIC · ⊞ 8.3K · ◷

• expires on Aug 22, 2026, 8:54 PM UTC-08:00

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

[github-actions]

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

[github-actions]

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #54144 does not have the 'implementation' label and has only 53 new lines of code in business logic directories (threshold: 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

[github-actions]

❌ Ponytail Reviewer failed. Please review the logs for details.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Generated by Ponytail Reviewer for #54144

[github-actions]

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

[github-actions]

Skills-Based Review 🧠

Applied /tdd — approving; the parallelization is safe and well-reasoned.

📋 Assessment

Positive Highlights

• ✅ Safety exclusion list is thorough and clearly documented (t.Setenv, os.Stdout/os.Stderr redirection, shared stubs, fixed ports, timing-dependent tests all correctly left out)
• ✅ Each t.Parallel() is placed as the very first statement in the top-level test function — correct Go convention
• ✅ t.TempDir() usage throughout the zip-extraction tests ensures parallel-safe filesystem isolation
• ✅ Validation (go test -race) was run on all modified tests before merging
• ✅ Table-driven subtests intentionally left unparallelized where loop-variable rebinding would be required — avoids silent data-race introduction

No actionable issues

All t.Parallel() additions are in functions that are stateless, use only t.TempDir() for filesystem access, and carry no shared mutable globals. The PR scope is strictly additive (53 lines, 0 deletions), making regression risk minimal.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 22.6 AIC · ⌖ 9.85 AIC · ⊞ 7.8K
_{Comment /matt to run again}

[github-actions]

Comment Memory

reviewed_at: 2026-08-20T00:00:00Z
review_event: COMMENT
top_themes:
- no actionable blocking issues found
- t.Parallel additions limited to top-level tests using isolated temp dirs
- existing subtests remain sequential where loop capture/shared fixtures would be risky
files_reviewed:
- pkg/cli/logs_engine_filter_test.go
- pkg/cli/logs_extract_zip_test.go
- pkg/cli/logs_firewall_filter_test.go
- pkg/cli/logs_formatting_test.go
- pkg/cli/logs_github_rate_limit_usage_test.go
- pkg/cli/logs_json_test.go
- pkg/cli/logs_mcp_tool_usage_test.go
- pkg/cli/logs_missing_data_test.go
- pkg/cli/logs_missing_tool_test.go
- pkg/cli/logs_noop_test.go
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 11 AIC · ⌖ 4.85 AIC · ⊞ 4K · ◷
_{Comment /review to run again}

[github-actions]

The changes are straightforward and safe: only t.Parallel() calls added to top-level test functions. All shared state uses t.TempDir() (parallel-safe). No os.Setenv, os.Chdir, or other global state mutations detected. ✅

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 21.7 AIC · ⌖ 8.79 AIC · ⊞ 5.7K

[github-actions]

Verdict

No blocking issues found in the changed lines.

Highlights

I checked the added t.Parallel() calls against the affected tests’ fixture patterns and did not find a changed-line correctness or isolation bug worth blocking on. The touched tests use per-test temp dirs or purely local data, and the author explicitly left riskier cases (env mutation, stdio redirection, fixed-port/timing-sensitive tests) untouched.

I also attempted to collect advisory findings from grumpy-coder, but no output was available, so this review is based on my own pass only.

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 11 AIC · ⌖ 4.85 AIC · ⊞ 4K
_{Comment /review to run again}

[Copilot]

Pull request overview

Adds safe top-level test parallelism across pkg/cli to reduce test runtime without changing assertions or production behavior.

Changes:

• Adds t.Parallel() to independently isolated tests.
• Retains sequential execution for table-driven subtests.

Show a summary per file

File	Description
pkg/cli/logs_noop_test.go	Parallelizes noop extraction tests.
pkg/cli/logs_missing_tool_test.go	Parallelizes missing-tool tests.
pkg/cli/logs_missing_data_test.go	Parallelizes missing-data tests.
pkg/cli/logs_mcp_tool_usage_test.go	Parallelizes MCP aggregation tests.
pkg/cli/logs_json_test.go	Parallelizes logs-data and JSON tests.
pkg/cli/logs_github_rate_limit_usage_test.go	Parallelizes rate-limit parsing tests.
pkg/cli/logs_formatting_test.go	Parallelizes formatting tests.
pkg/cli/logs_firewall_filter_test.go	Parallelizes firewall tests.
pkg/cli/logs_extract_zip_test.go	Parallelizes ZIP extraction tests.
pkg/cli/logs_engine_filter_test.go	Parallelizes engine/runtime filter tests.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 10/10 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.87.2