Uh oh!
There was an error while loading. Please reload this page.
Re-diagnose q workflow success rate as command gating, not execution failure - #54854
Merged
pelikhan merged 3 commits intoAug 22, 2026
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…ification in meta-orchestrators Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Copilot RequestRe-diagnose Aug 22, 2026
q workflow success rate as command gating, not execution failurepelikhan
marked this pull request as ready for review
August 22, 2026 16:45
Uh oh!
There was an error while loading. Please reload this page.
pelikhan
deleted the
copilot/fix-9919-1036865607-f7a577f4-ad52-44b9-8f08-81d2ea488992
branch
August 22, 2026 16:45
Contributor
There was a problem hiding this comment.
Pull request overview
Reclassifies q’s low activation ratio as expected slash-command gating and prevents stale attribution to PR #43527.
Changes:
- Updates analyzer and health-manager prompts.
- Regenerates their body hashes.
- Includes unrelated generated workflow changes, including strict-mode downgrades.
Show a summary per file
| File | Description |
|---|---|
agent-performance-analyzer.md | Adds gating and root-cause guidance. |
agent-performance-analyzer.lock.yml | Updates prompt body hash. |
workflow-health-manager.md | Mirrors diagnostic guidance. |
workflow-health-manager.lock.yml | Updates prompt body hash. |
smoke-drive.lock.yml | Unrelated shell regeneration. |
mcp-inspector.lock.yml | Disables compiled strict mode. |
gpclean.lock.yml | Disables compiled strict mode. |
example-permissions-warning.lock.yml | Disables compiled strict mode. |
dev.lock.yml | Disables compiled strict mode. |
daily-team-evolution-insights.lock.yml | Disables compiled strict mode. |
copilot-pr-merged-report.lock.yml | Disables compiled strict mode. |
cli-version-checker.lock.yml | Disables compiled strict mode. |
cli-consistency-checker.lock.yml | Disables compiled strict mode. |
blog-auditor.lock.yml | Disables compiled strict mode. |
ace-editor.lock.yml | Disables compiled strict mode. |
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 15
- Review effort level: Balanced
Comment on lines
+117
to
+118
| **Command- and mention-triggered workflows:** Workflows whose frontmatter uses `slash_command`, | ||
| `command`, or `mention` (for example `q`) are wired to `issues`, `issue_comment`, `discussion`, and |
Comment on lines
+126
to
+131
| **Root-cause hygiene:** Before repeating a root cause carried over from shared memory | ||
| (`shared-alerts.md`, `workflow-health-latest.md`), re-verify it against current evidence. If the note | ||
| cites a PR or issue as the pending fix, check its current state: when it is already merged or closed | ||
| and the metric has not moved, the attribution is stale — delete or replace it in `shared-alerts.md` | ||
| and re-diagnose from the workflow's trigger configuration and recent run logs instead of restating | ||
| it. |
Comment on lines
+121
to
+122
| - Exclude command- and mention-triggered workflows (frontmatter `slash_command`, `command`, or | ||
| `mention`, for example `q`) from execution-rate scoring. They start a run for every issue, |
Comment on lines
+127
to
+130
| - Re-verify any root cause carried over from `shared-alerts.md` or `workflow-health-latest.md` before | ||
| repeating it. If the note names a PR or issue as the pending fix and that PR/issue is already | ||
| merged or closed while the metric is unchanged, the attribution is stale: remove or replace it in | ||
| `shared-alerts.md` and re-diagnose from the workflow's trigger configuration and recent run logs. |
| GH_AW_INFO_CACHE_MEMORY: "true" | ||
| GH_AW_INFO_FRONTMATTER_EMOJI: "🔍" | ||
| GH_AW_COMPILED_STRICT: "true" | ||
| GH_AW_COMPILED_STRICT: "false" |
| GH_AW_INFO_CACHE_MEMORY: "true" | ||
| GH_AW_INFO_FRONTMATTER_EMOJI: "🔢" | ||
| GH_AW_COMPILED_STRICT: "true" | ||
| GH_AW_COMPILED_STRICT: "false" |
| GH_AW_INFO_AGENT_RUNTIME: "cloud-hypervisor" | ||
| GH_AW_INFO_FRONTMATTER_EMOJI: "✅" | ||
| GH_AW_COMPILED_STRICT: "true" | ||
| GH_AW_COMPILED_STRICT: "false" |
| GH_AW_INFO_AGENT_RUNTIME: "cloud-hypervisor" | ||
| GH_AW_INFO_FRONTMATTER_EMOJI: "📝" | ||
| GH_AW_COMPILED_STRICT: "true" | ||
| GH_AW_COMPILED_STRICT: "false" |
| GH_AW_INFO_AGENT_RUNTIME: "cloud-hypervisor" | ||
| GH_AW_INFO_FRONTMATTER_EMOJI: "✏️" | ||
| GH_AW_COMPILED_STRICT: "true" | ||
| GH_AW_COMPILED_STRICT: "false" |
Comment on lines
+1810
to
+1811
| if [ -d /tmp/gh-aw/sandbox/firewall/logs ]; then mkdir -p /tmp/gh-aw/threat-detection/sandbox/firewall/logs && cp -r /tmp/gh-aw/sandbox/firewall/logs/. /tmp/gh-aw/threat-detection/sandbox/firewall/logs/; fi | ||
| if [ -d /tmp/gh-aw/sandbox/firewall/audit ]; then mkdir -p /tmp/gh-aw/threat-detection/sandbox/firewall/audit && cp -r /tmp/gh-aw/sandbox/firewall/audit/. /tmp/gh-aw/threat-detection/sandbox/firewall/audit/; fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reported "0.8% execution success" for the
qworkflow is not a failure mode.qis a slash-command workflow, so GitHub starts a run for every issue/comment/discussion event and the generated gate stops it unless the body starts with/q— 2 activated runs out of 261 at ~9.9s average is the designed behavior. PR #43527 (shared prompt quality gate for agent-review workflows) was never wired intoq; that attribution was wrong from the start and kept being carried forward throughshared-alerts.md.The gate is visible in the compiled activation condition:
qitself needs no change. The defect is in how the meta-orchestrators score and remember it.agent-performance-analyzer.mdslash_command/command/mentionworkflows, score only activated runs and report the rest as "command gating (expected)" instead of as execution-success or activation-refused problems.shared-alerts.md/workflow-health-latest.md; if it names a PR/issue as the pending fix and that PR/issue is merged or closed while the metric is unchanged, drop it and re-diagnose from trigger config and run logs.shared-alerts.mdwrite step.workflow-health-manager.mdshared-alerts.mdpruning bullet.Lock files
agent-performance-analyzer.lock.ymlandworkflow-health-manager.lock.yml(prompt body is runtime-imported, so only the body hash changes).Note:
shared-alerts.mdlives in runtime repo-memory on thememory/meta-orchestratorsbranch and can't be edited from here — the pruning rule is what makes the next orchestrator run remove the stale note.