Skip to content

Verify network.allowed field is importable and merges domains correctly - #5645

Closed
pelikhan with Copilot wants to merge 1 commit into
mainfrom
copilot/make-network-allowed-importable
Closed

Verify network.allowed field is importable and merges domains correctly#5645
pelikhan with Copilot wants to merge 1 commit into
mainfrom
copilot/make-network-allowed-importable

Conversation

CopilotAI commented Dec 6, 2025

Copy link
Copy Markdown
Contributor

The network.allowed field is already fully importable. The compiler correctly merges domains from imported workflows.

Implementation Status

No changes required - feature is fully functional:

  • Schema: network field defined in both main_workflow_schema.json and included_file_schema.json
  • Parser: extractNetworkFromContent() extracts network config during import traversal
  • Merge Logic: MergeNetworkPermissions() combines domains with deduplication and sorting
  • Integration: Network merging integrated in compilation pipeline at compiler.go:781-786

Production Usage

Shared network configs work as expected:

# .github/workflows/shared/python-dataviz.mdnetwork:
allowed:
- defaults
- python# Workflows importing this file inherit the network configimports:
- shared/python-dataviz.md

Multiple workflows (daily-copilot-token-report.md, copilot-pr-nlp-analysis.md, etc.) successfully import and merge network domains.

Test Coverage

All existing tests pass:

  • Basic import/merge (TestNetworkMergeWithImports)
  • Multiple imports with ecosystems (TestNetworkMergeMultipleImports)
  • Edge cases: duplicates, empty configs (TestNetworkMergeEdgeCases)
Original prompt

Make sure the network.allowed field is importable. The compiler should merge the set of domains from imported workflows


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

CopilotAI changed the title [WIP] Make network.allowed field importable and merge domainsVerify network.allowed field is importable and merges domains correctlyDec 6, 2025
CopilotAI requested a review from pelikhanDecember 6, 2025 01:21
@pelikhanpelikhan closed this Dec 6, 2025
@pelikhan
pelikhan deleted the copilot/make-network-allowed-importable branch December 15, 2025 04:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pelikhan