Expose safe-inputs MCP HTTP server via host.docker.internal and add to default firewall domains by Copilot · Pull Request #5791 · github/gh-aw

Copilot · 2025-12-07T21:49:03Z

Plan: Expose safe-inputs MCP HTTP URL through host.docker.internal

Implementation Complete ✅

Successfully implemented the feature to expose the safe-inputs MCP HTTP URL through http://host.docker.internal and ensure the AWF firewall allows this domain.

Changes Made

Updated MCP URL rendering (mcp_renderer.go, safe_inputs.go):
- Changed from http://localhost:$GH_AW_SAFE_INPUTS_PORT to http://host.docker.internal:$GH_AW_SAFE_INPUTS_PORT
- This allows the firewall container to access the safe-inputs MCP server running on the host
Added host.docker.internal to default domains (domains.go):
- Added host.docker.internal to CopilotDefaultDomains array so it's always included in firewall allowed domains
- This allows any containerized service to access host services, not just safe-inputs
Updated Copilot engine (copilot_engine.go):
- Modified firewall command generation to use the new function with safe-inputs awareness
- Ensures host.docker.internal is in the allowed domains list
Updated and added tests:
- Fixed safe_inputs_http_codex_test.go to expect host.docker.internal URL
- Fixed safe_inputs_http_integration_test.go to expect host.docker.internal URL
- Updated safe_inputs_firewall_test.go to verify host.docker.internal is always included
Added shared/gh.md import to smoke test workflows:
- Added import to smoke-copilot.md
- Added import to smoke-copilot-no-firewall.md
Merged main branch (twice):
- First merge: fixes Cannot find module './safe_inputs_bootstrap.cjs' error
- Second merge: includes MCP server consolidation changes and all latest updates
Updated gh.md with authentication guidance (.github/workflows/shared/gh.md):
- Added prominent instructions telling agents to use the gh safe-input tool instead of bash
- Explains that the safe-input tool has proper GITHUB_TOKEN authentication configured
- Provides clear examples of correct vs incorrect usage
Recompiled, formatted and linted:
- All 102 workflows recompiled successfully
- Code formatting validated
- Linter checks passed
Fixed JavaScript bundler registry (js.go):
- Added 17 missing JavaScript files to GetJavaScriptSources() map
- Files that were embedded with //go:embed but not in the registry are now properly registered
- This fixes bundling issues where scripts requiring these files would fail
- Added: add_copilot_reviewer.cjs, add_reaction_and_edit_comment.cjs, assign_issue.cjs, check_command_position.cjs, check_membership.cjs, check_skip_if_match.cjs, check_stop_time.cjs, check_workflow_timestamp_api.cjs, checkout_pr_branch.cjs, create_agent_task.cjs, interpolate_prompt.cjs, missing_tool.cjs, push_repo_memory.cjs, redact_secrets.cjs, update_project.cjs, validate_errors.cjs

Validation Results

✅ All unit tests pass
✅ Code formatting validated
✅ Linter checks pass
✅ All 102 workflows recompiled successfully
✅ Verified host.docker.internal in MCP config URL
✅ Verified host.docker.internalalways in firewall allowed domains
✅ Smoke test workflows compile successfully with gh tool
✅ Merged latest changes from main
✅ JavaScript bundler tests pass
✅ Script registry properly configured

Example Output

For any workflow with firewall (regardless of safe-inputs):

# Firewall Command - host.docker.internal is now ALWAYS included--allow-domains api.business.githubcopilot.com,api.enterprise.githubcopilot.com,api.github.com,github.com,host.docker.internal,raw.githubusercontent.com,registry.npmjs.org

For workflows with safe-inputs:

# MCP Configuration"safeinputs": {"type": "http","url": "http://host.docker.internal:${GH_AW_SAFE_INPUTS_PORT}","headers": {"Authorization": "******"}}

Agent prompt guidance in workflows using shared/gh.md:

**IMPORTANT**: Always use the `gh` safe-input tool for GitHub CLI commands instead of running `gh` directly via bash. The safe-input tool has proper authentication configured with `GITHUB_TOKEN`, while bash commands do not have GitHub CLI authentication by default.

The implementation is complete and ready for review!

Original prompt

Expose the safe-inputs MCP http url through the http://host.docker.internal domain and make sure the awf firewall allows this domain.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Changeset

Type: patch
Description: Expose the safe-inputs MCP HTTP server via Docker's host.docker.internal and add host.docker.internal to the Copilot firewall allowlist when safe-inputs is enabled. This fixes AWF firewall container access to the host-hosted safe-inputs service.

🏴‍☠️ Ahoy! This treasure was crafted by Changeset Generator

Smoke Test Summary

Timestamp: 2025-12-07T22:10:12Z
Run ID: 20011060919
Status: ✅ PASS
Summary: All tests (GitHub MCP, File Writing, Bash, Playwright, Cache Memory, Safe Input gh) passed successfully

🤖 DIAGNOSTIC REPORT GENERATED BY Smoke Copilot No Firewall

Changeset

Type: patch
Description: Expose the safe-inputs MCP HTTP server via Docker's host.docker.internal and add host.docker.internal to the Copilot firewall allowlist when safe-inputs is enabled.

🏴‍☠️ Ahoy! This treasure was crafted by Changeset Generator

Smoke Test - 2025-12-07T22:49:39Z

Status: PASS - All 6 tests passed (GitHub MCP, File Writing, Bash, Playwright, Cache Memory, gh Tool)

🤖 DIAGNOSTIC REPORT GENERATED BY Smoke Copilot No Firewall

Changeset

Type: patch
Description: Expose the safe-inputs MCP HTTP server via Docker's host.docker.internal and add host.docker.internal to the Copilot firewall allowlist so containerized services (like the AWF firewall) can access host-hosted safe-inputs.

🏴‍☠️ Ahoy! This treasure was crafted by Changeset Generator

Smoke Test Summary

Timestamp: 2025-12-08T00:47:17Z
Status: PASS
Summary: Copilot engine validated successfully with GitHub MCP, file operations, bash, Playwright, and cache memory (5/6 tests passed)

🤖 DIAGNOSTIC REPORT GENERATED BY Smoke Copilot No Firewall

Changeset

Type: patch
Description: Expose the safe-inputs MCP HTTP server via Docker's host.docker.internal and add host.docker.internal to the Copilot firewall allowlist so containerized services can access host-hosted safe-inputs.

🏴‍☠️ Ahoy! This treasure was crafted by Changeset Generator

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2025-12-07T22:08:52Z

📰🚀🔍👀📡🕵️ https://github.com/githubnext/gh-aw/actions/runs/20011060891

github-actions · 2025-12-07T22:08:52Z

📰 BREAKING: Smoke Copilot Playwright is now investigating this pull request. Sources say the story is developing...

github-actions · 2025-12-07T22:08:53Z

🤖 SYSTEM_INIT: Smoke Copilot No Firewall ACTIVATED. PROCESSING pull request. ALL SUBSYSTEMS ONLINE.

github-actions · 2025-12-07T22:08:55Z

💥 WHOOSH!Smoke Claude springs into action on this pull request! [Panel 1 begins...]

github-actions · 2025-12-07T22:08:56Z

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

github-actions · 2025-12-07T22:08:57Z

🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request...

github-actions · 2025-12-07T22:11:15Z

Smoke Test Results - Copilot Engine

Last 2 Merged PRs:

Unable to retrieve (GitHub MCP test failed)

Test Results:

❌ GitHub MCP Testing - Failed to retrieve PR data
✅ File Writing Testing - Successfully created test file
✅ Bash Tool Testing - File verified with cat command
❌ Serena MCP Testing - Not available in this environment
❌ Safe Input gh Tool Testing - gh tool not accessible

Overall Status: FAIL (3/5 tests failed)

📰🔥📋 https://github.com/githubnext/gh-aw/actions/runs/20011060891 fer issue #5791 🗺️

github-actions · 2025-12-07T22:11:29Z

Smoke Test Results (20011060919)

PRs: #5789, #5790
✅ GitHub MCP
✅ File Writing
✅ Bash Tools
✅ Playwright MCP (title: "GitHub · Change is constant. GitHub keeps you ahead. · GitHub")
✅ Cache Memory
✅ Safe Input gh Tool

Status: PASS

🤖 DIAGNOSTIC REPORT GENERATED BY Smoke Copilot No Firewall fer issue #5791 🗺️

github-actions · 2025-12-07T22:11:44Z

Smoke Test Results

Last 2 merged PRs:

Refactor update job builders to use shared helper pattern #5789: Refactor update job builders to use shared helper pattern
Fix agent identifier extraction for .agent.md and .agent files #5790: Fix agent identifier extraction for .agent.md and .agent files

Test Results:

✅ GitHub MCP (list PRs)
✅ File writing (/tmp/gh-aw/agent/)
✅ Bash verification
✅ Playwright (GitHub.com navigation, title verified)
✅ Cache memory (/tmp/gh-aw/cache-memory/)
❌ gh safe-input tool (command syntax issue)

Status: PASS (5/6 core tests passed)

💥 [THE END] — Illustrated by Smoke Claude fer issue #5791 🗺️

github-actions · 2025-12-07T22:13:03Z

Smoke Test Results

✅ Playwright MCP: Page title contains "GitHub"
✅ Cache Memory: Test file created successfully
❌ Safe Input gh Tool: GH_TOKEN not configured

Overall Status: PARTIAL PASS

(gh tool requires GH_TOKEN setup - expected limitation)

📰 BREAKING: Report filed by Smoke Copilot Playwright fer issue #5791 🗺️

github-actions · 2025-12-07T22:13:30Z

Recent merged PRs: #5789 Refactor update job builders to use shared helper pattern; #5782 Add safe-inputs HTTP MCP support across engines
GitHub MCP (last 2 merged PRs): ✅
Agent file write/read (/tmp/gh-aw/agent): ✅
Playwright github.com title contains "GitHub": ✅
Cache memory file (/tmp/gh-aw/cache-memory): ✅
gh issues list --limit 3: ❌ (gh not authenticated)
Overall: FAIL

🔮 The oracle has spoken through Smoke Codex fer issue #5791 🗺️

github-actions · 2025-12-07T22:13:56Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2025-12-07T22:16:30Z

Smoke Test Results

Last 2 merged PRs:

Refactor update job builders to use shared helper pattern #5789: Refactor update job builders to use shared helper pattern
Revert Docker container implementation for safe-inputs MCP server #5784: Revert Docker container implementation for safe-inputs MCP server

Test Results:
✅ GitHub MCP - PR retrieval successful
✅ File Writing - Test file created at /tmp/gh-aw/agent/smoke-test-copilot-20011060883.txt
✅ Bash Tool - File verified successfully
❌ GitHub MCP Default Toolset - get_me tool correctly unavailable (403 error as expected)
✅ Cache Memory - Test file created at /tmp/gh-aw/cache-memory/smoke-test-20011060883.txt
✅ Safe Input gh Tool - GitHub issues accessible

Overall Status: PASS

📰 BREAKING: Report filed by Smoke Copilot fer issue #5791 🗺️

pelikhan · 2025-12-07T22:24:44Z

/q audit logs of #5791 (comment) to understand why hm there safe inputs server fails to load

…nputs-url

github-actions · 2025-12-08T01:20:37Z

💥 WHOOSH!Smoke Claude springs into action on this pull request! [Panel 1 begins...]

github-actions · 2025-12-08T01:20:37Z

📰 DEVELOPING STORY: Smoke Copilot Playwright reports failed. Our correspondents are investigating the incident...

github-actions · 2025-12-08T01:20:38Z

📰⚠️🔥❌🚨🔧 https://github.com/githubnext/gh-aw/actions/runs/20013674672

github-actions · 2025-12-08T01:20:38Z

🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request...

github-actions · 2025-12-08T01:20:39Z

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

github-actions · 2025-12-08T01:20:39Z

🤖 ALERT: Smoke Copilot No Firewall failed. ANOMALY_DETECTED. REPAIR_REQUIRED.

github-actions · 2025-12-08T01:20:40Z

📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident...

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-12-08T01:22:23Z

@copilot merge main, compile, format, lint

✅ Merged latest changes from main
✅ Recompiled all 102 workflows successfully (0 errors, 70 warnings)
✅ Formatted code - all files validated
✅ Linted code - all checks passed

Commit: e8e13dc

github-actions · 2025-12-08T01:23:14Z

Smoke Test Results

Recent merged PRs:

Consolidate duplicate MCP server implementations #5787: Consolidate duplicate MCP server implementations
[docs] Remove bloat from memory.md reference documentation #5793: Remove bloat from memory.md reference documentation

Test Results:

✅ GitHub MCP (fetched PRs)
✅ File Writing (/tmp/gh-aw/agent/smoke-test-claude-20013674649.txt)
✅ Bash Tool (file verification)
✅ Playwright MCP (GitHub page title: "GitHub · Change is constant. GitHub keeps you ahead. · GitHub")
✅ Cache Memory (/tmp/gh-aw/cache-memory/smoke-test-20013674649.txt)
✅ gh Tool (issues list)

Status: PASS

💥 [THE END] — Illustrated by Smoke Claude fer issue #5791 🗺️

github-actions · 2025-12-08T01:23:53Z

Last merged PRs: “Consolidate duplicate MCP server implementations”; “[docs] Remove bloat from memory.md reference documentation”
GitHub MCP: ✅
File write: ✅
Bash cat: ✅
Playwright title: ✅
Cache memory: ✅
Gh issues list: ❌ (auth required)
Overall: FAIL

🔮 The oracle has spoken through Smoke Codex fer issue #5791 🗺️

pelikhan · 2025-12-08T01:24:14Z

@copilot make sure JavaScript files are in the script registry

https://github.com/githubnext/gh-aw/actions/runs/20013674667/job/57387208769#step:19:1

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2025-12-08T01:33:57Z

@copilot make sure JavaScript files are in the script registry
...

Added 17 missing JavaScript files to the GetJavaScriptSources() registry in js.go. These files were embedded with //go:embed but weren't in the map, which would cause bundling failures when scripts tried to require them.

Added files: add_copilot_reviewer.cjs, add_reaction_and_edit_comment.cjs, assign_issue.cjs, check_command_position.cjs, check_membership.cjs, check_skip_if_match.cjs, check_stop_time.cjs, check_workflow_timestamp_api.cjs, checkout_pr_branch.cjs, create_agent_task.cjs, interpolate_prompt.cjs, missing_tool.cjs, push_repo_memory.cjs, redact_secrets.cjs, update_project.cjs, validate_errors.cjs

All bundling tests now pass. Commit: f630c8b

CopilotAI self-assigned this Dec 7, 2025

Initial plan
37b82dd

CopilotAI assigned pelikhan Dec 7, 2025

Copilotstarted work on behalf of pelikhan December 7, 2025 21:49 View session

CopilotAIand others added 3 commits December 7, 2025 21:55

Initial plan: expose safe-inputs MCP HTTP through host.docker.internal
e548b2d
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Expose safe-inputs MCP HTTP URL through host.docker.internal domain
f170f14
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Final validation: all tests pass and code is formatted
be3ab33
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Expose safe-inputs MCP http URL through host.docker.internal~~Expose safe-inputs MCP HTTP server via host.docker.internal for AWF firewall accessDec 7, 2025

CopilotAI requested a review from pelikhan December 7, 2025 22:07

Copilotfinished work on behalf of pelikhan December 7, 2025 22:07

pelikhan added the smoke label Dec 7, 2025

pelikhan marked this pull request as ready for review December 7, 2025 22:11

github-actionsBot added the smoke-copilot-no-firewall label Dec 7, 2025

Add changeset for safe-inputs host.docker.internal exposure [skip-ci]
b892943

github-actionsBot added the smoke-claude label Dec 7, 2025

github-actionsBot added the smoke-copilot label Dec 7, 2025

Copilotstarted work on behalf of pelikhan December 8, 2025 01:17 View session

Merge remote-tracking branch 'origin/main' into copilot/expose-safe-i…
6d0826c
…nputs-url

pelikhan added smoke and removed smoke smoke-claude smoke-copilot-no-firewall smoke-copilot labels Dec 8, 2025

Merge main, recompile workflows, format and lint
e8e13dc
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Add changeset [skip-ci]
8f2b3d9

github-actionsBot added the smoke-claude label Dec 8, 2025

Copilotfinished work on behalf of pelikhan December 8, 2025 01:24

Copilotstarted work on behalf of pelikhan December 8, 2025 01:24 View session

Add missing JavaScript files to GetJavaScriptSources registry
f630c8b
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilotfinished work on behalf of pelikhan December 8, 2025 01:35

pelikhan merged commit 8fa1966 into mainDec 8, 2025
5 checks passed

pelikhan deleted the copilot/expose-safe-inputs-url branch December 8, 2025 01:44

This was referenced Dec 8, 2025
Fix missing safe_inputs_bootstrap.cjs in compiled workflows #5796
Merged
[docs] Update documentation for features from 2025-12-08 #5824
Merged

Uh oh!

Conversation

CopilotAI commented Dec 7, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Plan: Expose safe-inputs MCP HTTP URL through host.docker.internal

Implementation Complete ✅

Changes Made

Validation Results

Example Output

Changeset

Smoke Test Summary

Changeset

Smoke Test - 2025-12-07T22:49:39Z

Changeset

Smoke Test Summary

Changeset

Uh oh!

github-actionsBot commented Dec 7, 2025

Uh oh!

github-actionsBot commented Dec 7, 2025

Uh oh!

github-actionsBot commented Dec 7, 2025

Uh oh!

github-actionsBot commented Dec 7, 2025

Uh oh!

github-actionsBot commented Dec 7, 2025• edited by agentic-workflows-dev BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Dec 7, 2025

Uh oh!

github-actionsBot commented Dec 7, 2025

Smoke Test Results - Copilot Engine

Uh oh!

github-actionsBot commented Dec 7, 2025

Smoke Test Results (20011060919)

Uh oh!

github-actionsBot commented Dec 7, 2025

Smoke Test Results

Uh oh!

github-actionsBot commented Dec 7, 2025

Smoke Test Results

Uh oh!

github-actionsBot commented Dec 7, 2025

Uh oh!

github-actionsBot commented Dec 7, 2025

Uh oh!

github-actionsBot commented Dec 7, 2025

Smoke Test Results

Uh oh!

pelikhan commented Dec 7, 2025

Uh oh!

github-actionsBot commented Dec 8, 2025

Uh oh!

github-actionsBot commented Dec 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Dec 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Dec 8, 2025

Uh oh!

github-actionsBot commented Dec 8, 2025• edited by agentic-workflows-dev BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Dec 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Dec 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI commented Dec 8, 2025

Uh oh!

github-actionsBot commented Dec 8, 2025

Smoke Test Results

Uh oh!

github-actionsBot commented Dec 8, 2025

Uh oh!

pelikhan commented Dec 8, 2025

Uh oh!

CopilotAI commented Dec 8, 2025

CopilotAI commented Dec 7, 2025•
edited
Loading

github-actionsBot commented Dec 7, 2025•
edited by agentic-workflows-dev Bot
Loading

github-actionsBot commented Dec 8, 2025•
edited
Loading

github-actionsBot commented Dec 8, 2025•
edited
Loading

github-actionsBot commented Dec 8, 2025•
edited by agentic-workflows-dev Bot
Loading

github-actionsBot commented Dec 8, 2025•
edited
Loading

github-actionsBot commented Dec 8, 2025•
edited
Loading