Skip to content

Fix duplicate validateEngineStub declaration breaking linter and tests - #8536

Merged
pelikhan merged 2 commits into
mainfrom
copilot/lint-go-and-review-tests
Jan 2, 2026
Merged

Fix duplicate validateEngineStub declaration breaking linter and tests#8536
pelikhan merged 2 commits into
mainfrom
copilot/lint-go-and-review-tests

Conversation

CopilotAI commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

Duplicate validateEngineStub function in pkg/cli/add_command_test.go and pkg/cli/flags_test.go caused compilation failure, breaking both linter and security test runs.

Changes

  • Removed duplicate declaration from flags_test.go, keeping single definition in add_command_test.go
  • Fixed testifylint violations across 4 test files: changed assert.Error/NoError to require.Error/NoError for error assertions (9 instances)
// Before (testifylint violation)assert.Error(t, err, "Should error")
assert.NoError(t, err, "Should not error")
// After (correct usage)require.Error(t, err, "Should error")
require.NoError(t, err, "Should not error")

Files modified: flags_test.go, actions_build_command_test.go, add_command_test.go, generate_action_metadata_command_test.go, logs_command_test.go

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login g_.a 9615979/b304/vet.cfg /bin/sh -p workflow_test -lang=go1.18 /bin/sh -c -node.git -goversion /usr/bin/git -c=4 -nolocalimports -importcfg ortcfg (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login oad-artifact.git -trimpath /usr/bin/git -p github.com/githuapi l/linux_amd64/couser git rev-�� k/gh-aw/gh-aw/.github/workflows l/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login f/tags/v6 go /usr/bin/git -json GO111MODULE ux-amd64/pkg/toolist git conf�� k/gh-aw/gh-aw/.github/workflows remote.origin.url (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Reference: https://github.com/githubnext/gh-aw/actions/runs/20647831216/job/59287810762

Lint go
Review security tests


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI changed the title [WIP] Lint Go code and review security testsFix duplicate validateEngineStub declaration breaking linter and testsJan 2, 2026
CopilotAI requested a review from pelikhanJanuary 2, 2026 00:38
@pelikhan
pelikhan marked this pull request as ready for review January 2, 2026 00:40
@pelikhan
pelikhan merged commit 467489f into mainJan 2, 2026
4 checks passed
@pelikhan
pelikhan deleted the copilot/lint-go-and-review-tests branch January 2, 2026 00:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pelikhan