Fix add_comment and update_* safe outputs ignoring target configuration

[Copilot]

The add_comment handler extracted the target configuration but never used it, causing comments to target the wrong PR/issue. In run #20652597117, a workflow triggered by PR #8535 incorrectly commented on unrelated PR #21.

During investigation, found 3 more handlers with the same bug pattern: update_issue.cjs, update_discussion.cjs, and update_pull_request.cjs. All four handlers have been fixed in this PR.

Changes

actions/setup/js/add_comment.cjs

• Import resolveTarget() from safe_output_helpers.cjs
• Replace manual context resolution with standardized target handling
• Preserve discussion-specific logic (separate code path)

actions/setup/js/add_comment.test.cjs (new)

• Add 7 tests covering all target modes: "triggering", explicit numbers, "*" with item_number
• Include regression test for the PR Enable MCP gateway (awmg) in smoke-copilot-no-firewall workflow with built-in mode, fix compile timestamp handling, and enhance health check logging #8535 → Make compute-text step lazily inserted only when needed #21 scenario

actions/setup/js/update_issue.cjs

• Import resolveTarget() from safe_output_helpers.cjs
• Replace manual target resolution with standardized helper
• Now supports explicit numbers and wildcard mode

actions/setup/js/update_discussion.cjs

• Import resolveTarget() from safe_output_helpers.cjs
• Add explicit number target support with improved validation
• Enhanced error messages

actions/setup/js/update_pull_request.cjs

• Import resolveTarget() from safe_output_helpers.cjs
• Replace manual target resolution with standardized helper
• Now supports explicit numbers and wildcard mode

Before/After

// Before: target config ignoreditemNumber=contextIssue||contextPR;// Always uses context// After: target config respectedconsttargetResult=resolveTarget({targetConfig: commentTarget,// Now uses configitem: item,context: context,itemType: "add_comment",supportsPR: true,});itemNumber=targetResult.number;

Impact

All four handlers now consistently support:

• "triggering" mode (default) - uses workflow trigger context
• Explicit number targets (e.g., target: "42") - targets specific issue/PR/discussion
• Wildcard mode (target: "*") - uses item_number/issue_number/pull_request_number from message

This fix prevents workflows from targeting the wrong PR/issue and provides consistent behavior across all safe-output handlers.

[!WARNING]

Custom agent used: debug-agentic-workflow
Debug and refine agentic workflows using gh-aw CLI tools - analyze logs, audit runs, and improve workflow performance

Custom agent used: debug-agentic-workflow
Debug and refine agentic workflows using gh-aw CLI tools - analyze logs, audit runs, and improve workflow performance

Original prompt

Reference: https://github.com/githubnext/gh-aw/actions/runs/20652597117/job/59299816067#step:29:1

Investigate why the safe output added a comment to the wrong PR (#21 is unrelated to this change). Review the add_comment.cjs logic , this agentic run to determine the root cause of the bug.

Custom agent used: debug-agentic-workflow
Debug and refine agentic workflows using gh-aw CLI tools - analyze logs, audit runs, and improve workflow performance

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[pelikhan]

@copilot search for other instances of JavaScript code resolving a target incorrectly, always use helper.

[Copilot]

@copilot search for other instances of JavaScript code resolving a target incorrectly, always use helper.

Found 3 more handlers with incorrect target resolution that should use the helper:

update_issue.cjs (lines 43, 82-99):

• Extracts updateTarget but only checks "triggering" mode
• Ignores explicit numbers and "*" wildcard

update_discussion.cjs (lines 76, 104-133):

• Extracts updateTarget but only checks "triggering" mode
• Ignores explicit numbers and "*" wildcard

update_pull_request.cjs (lines 78, 108-137):

• Extracts updateTarget but only checks "triggering" mode
• Ignores explicit numbers and "*" wildcard

All three should be refactored to use resolveTarget() from safe_output_helpers.cjs like add_comment.cjs now does.

Note: create_pr_review_comment.cjs already has proper target handling (lines 108-150) but uses inline logic instead of the helper - it works correctly but could be refactored for consistency.

[pelikhan]

@copilot fix update_*.cjs handlers

[Copilot]

@copilot fix update_*.cjs handlers

Fixed all three update_*.cjs handlers in commit fd682f3:

update_issue.cjs:

• Import resolveTarget() helper
• Replace manual resolution logic with standardized helper
• Now supports explicit numbers (e.g., target: "42") and wildcard mode (target: "*")

update_discussion.cjs:

• Import resolveTarget() helper
• Add explicit number target support
• Improved error messages and validation

update_pull_request.cjs:

• Import resolveTarget() helper
• Replace manual resolution logic with standardized helper
• Now supports explicit numbers (e.g., target: "123") and wildcard mode (target: "*")

All three handlers now consistently support the same target modes: "triggering" (default), explicit numbers, and wildcard with item_number in the message.

[pelikhan]

@copilot format and lint js

[Copilot]

@copilot format and lint js

All JavaScript files are already properly formatted and pass linting:

✅ make fmt-cjs - All files unchanged (already formatted)
✅ make lint-cjs - All matched files use Prettier code style

No changes needed.