Uh oh!
There was an error while loading. Please reload this page.
fix issue with pagination in search_repositories - #129
Merged
Conversation
juruenforce-pushed
the
juruen/fix-search-repository
branch
from
April 5, 2025 14:42
4e88e65 to
952641bComparejuruen
marked this pull request as ready for review
April 5, 2025 14:53
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a pagination bug in the search_repositories function by ensuring the correct parameter ("perPage") is used so that the specified number of results per page is honored.
- Updated the test input in pkg/github/search_test.go from "per_page" to "perPage".
- Updated the parameter processing in pkg/github/search.go to use "perPage".
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/search_test.go | Changes parameter key for test input consistency. |
| pkg/github/search.go | Applies the corrected parameter key in the code. |
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
williammartin
approved these changes
Apr 5, 2025
williammartin
left a comment
Collaborator
There was a problem hiding this comment.
Sorry, looks like I missed this one when I was mass find and replacing to do the conformance!
JohnDaWalka added a commit
to JohnDaWalka/github-mcp-server
that referenced
this pull request
Apr 5, 2025
fix issue with pagination in search_repositories (github#129)
AlexanderYastrebov added a commit
to AlexanderYastrebov/github-mcp-server
that referenced
this pull request
Apr 6, 2025
Page site tool parameter names were changed to `perPage` within github#129 while GitHub API uses `per_page` parameter name. This change fixes overlooked inconsistencies. Follow up on github#129Fixesgithub#136 Signed-off-by: Alexander Yastrebov <yastrebov.alex@gmail.com>
AlexanderYastrebov added a commit
to AlexanderYastrebov/github-mcp-server
that referenced
this pull request
Apr 6, 2025
Page size tool parameter names were changed to `perPage` within github#129 while GitHub API uses `per_page` parameter name. This change fixes overlooked inconsistencies. Follow up on github#129Fixesgithub#136 Signed-off-by: Alexander Yastrebov <yastrebov.alex@gmail.com>
AlexanderYastrebov added a commit
to AlexanderYastrebov/github-mcp-server
that referenced
this pull request
Apr 6, 2025
Page size tool parameter names were changed to `perPage` within github#90 while GitHub API uses `per_page` parameter name. This change fixes overlooked inconsistencies. Follow up on github#90 Follow up on github#129Fixesgithub#136 Signed-off-by: Alexander Yastrebov <yastrebov.alex@gmail.com>
williammartin pushed a commit
to AlexanderYastrebov/github-mcp-server
that referenced
this pull request
Apr 7, 2025
Page size tool parameter names were changed to `perPage` within github#90 while GitHub API uses `per_page` parameter name. This change fixes overlooked inconsistencies. Follow up on github#90 Follow up on github#129Fixesgithub#136 Signed-off-by: Alexander Yastrebov <yastrebov.alex@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #105
This PR makes sure that the
perPageparameter insearch_repositoriesis honored. Otherwise, we were always getting 30 results.