Skip to content

Update PR template to include tool renaming section - #1657

Merged
tommaso-moro merged 4 commits into
mainfrom
tommy/update-pr-template
Dec 23, 2025
Merged

Update PR template to include tool renaming section#1657
tommaso-moro merged 4 commits into
mainfrom
tommy/update-pr-template

Conversation

@tommaso-moro

@tommaso-morotommaso-moro commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Summary

Now that we support tool aliases for safe tool renaming, we need to ensure that aliases are introduced whenever tools are renamed. This PR updates the PR template to add a heads up to the dev opening the PR and thus ensure this process isn't neglected.

Why

If tools are renamed and their aliases are not updated, we risk breaking the server for users that have a hard reference to those tools in their server config

What changed

  • the template was updated to add a section on tool renaming

MCP impact

  • No tool or API changes
  • Tool schema or behavior changed
  • New tool added

Prompts tested (tool changes only)

  • n/a

Security / limits

  • No security or limits impact
  • Auth / permissions considered
  • Data exposure, filtering, or token/size limits considered

Lint & tests

  • Linted locally with ./script/lint
  • Tested locally with ./script/test

Docs

  • Not needed
  • Updated (README / docs / examples)

CopilotAI review requested due to automatic review settings December 19, 2025 18:13
@tommaso-moro
tommaso-moro requested a review from a team as a code ownerDecember 19, 2025 18:13
@tommaso-morotommaso-moro changed the title Update PR templateUpdate PR template to include tool renaming sectionDec 19, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the pull request template by adding a new "Tool renaming" section to ensure developers don't forget to update tool aliases when renaming tools, which would otherwise break the server for users with hard references to old tool names.

  • Adds a new "Tool renaming" section with checkboxes for developers to confirm whether they're renaming tools
  • Includes a reference to deprecated_tool_aliases.go where aliases should be added
  • Provides a link to documentation for detailed guidance on the tool renaming process

Comment thread.github/pull_request_template.md Outdated
Comment thread.github/pull_request_template.md
@tommaso-moro
tommaso-moro merged commit 95a637e into mainDec 23, 2025
15 checks passed
@tommaso-moro
tommaso-moro deleted the tommy/update-pr-template branch December 23, 2025 11:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tommaso-moro@SamMorrowDrums@scutuatua-crypto