Skip to content

chore: export repository funcs - #166

Merged
SamMorrowDrums merged 1 commit into
mainfrom
export-repositories
Apr 8, 2025
Merged

chore: export repository funcs#166
SamMorrowDrums merged 1 commit into
mainfrom
export-repositories

Conversation

@SamMorrowDrums

Copy link
Copy Markdown
Collaborator

Export repository funcs to the public interface.

CopilotAI review requested due to automatic review settings April 7, 2025 22:29

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the naming of various repository functions and tool definitions to export them on the public interface.

  • Renamed resource functions from lower-case to exported (capitalized) versions in pkg/github/server.go, pkg/github/repository_resource.go, and corresponding test files.
  • Updated tool functions in pkg/github/repositories.go and pkg/github/repositories_test.go to use capitalized, exported names.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
pkg/github/server.goUpdated calls to resource functions to their exported versions.
pkg/github/repository_resource_test.goUpdated tests to use exported resource handler functions.
pkg/github/repository_resource.goRenamed resource functions and handler to exported names.
pkg/github/repositories_test.goUpdated tests to use exported tool function names.
pkg/github/repositories.goRenamed tool functions to exported names.
Comments suppressed due to low confidence (1)

pkg/github/server.go:59

  • [nitpick] The function 'searchRepositories' remains unexported while other repository functions have been updated to exported versions. Consider renaming it to 'SearchRepositories' for naming consistency if it is meant to be part of the public interface.
s.AddTool(searchRepositories(client, t))

juruen
juruen previously approved these changes Apr 8, 2025

@juruenjuruen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Base automatically changed from export-prs to mainApril 8, 2025 07:33
@SamMorrowDrums
SamMorrowDrums dismissed juruen’s stale reviewApril 8, 2025 07:33

The base branch was changed.

@SamMorrowDrums
SamMorrowDrums merged commit c1bdd6a into mainApr 8, 2025
@SamMorrowDrums
SamMorrowDrums deleted the export-repositories branch April 8, 2025 07:34
DaleSeo pushed a commit to DaleSeo/github-mcp-server that referenced this pull request Oct 24, 2025
* feat: add Apify MCP Server
* fix icon
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@SamMorrowDrums@juruen