Skip to content

fix: use gh pr checkout to handle fork PRs in license-check workflow#1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamMorrowDrums merged 2 commits into from
Dec 31, 2025
+6 −2
Merged

fix: use gh pr checkout to handle fork PRs in license-check workflow #1709

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
124e3fe
Initial plan
Copilot Dec 31, 2025
0439e50
fix: use gh pr checkout to handle fork PRs in license-check workflow
Copilot Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/license-check.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,8 +25,12 @@ jobs:
steps:
- name: Check out code
uses: actions/checkout@v6
with:
ref: ${{ github.head_ref }}

# Check out the actual PR branch so we can push changes back if needed

CopilotAIDec 31, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment on line 29 accurately describes the purpose of this step. However, it could be more specific about the scenarios this handles. Consider expanding it to:

"Check out the actual PR branch so we can push changes back if needed. This uses 'gh pr checkout' which properly handles both same-repo and fork PRs, unlike the previous 'ref: github.head_ref' approach which fails for fork PRs."

This provides better context for future maintainers about why this approach was chosen.

Suggested change
# Check out the actual PR branch so we can push changes back if needed
# Check out the actual PR branch so we can push changes back if needed. This uses
# 'gh pr checkout' which properly handles both same-repo and fork PRs, unlike the
# previous 'ref: github.head_ref' approach which fails for fork PRs.

Copilot uses AI. Check for mistakes.
- name: Check out PR branch
env:
GH_TOKEN: ${{ github.token }}
run: gh pr checkout ${{ github.event.pull_request.number }}
Comment on lines +30 to +33

CopilotAIDec 31, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gh pr checkout command requires the GitHub CLI to be available in the runner. While ubuntu-latest runners typically have gh pre-installed, this dependency is implicit and could break if the runner image changes. Consider adding a comment documenting this requirement, or add an explicit step to ensure gh is available (e.g., using actions/github-cli-setup or verifying with gh --version).

Copilot uses AI. Check for mistakes.

- name: Set up Go
uses: actions/setup-go@v6
Expand Down