Skip to content

chore: remove unused github.com/fatih/color - #1875

Closed
alexandear wants to merge 2 commits into
github:mainfrom
alexandear-org:chore/remove-fatih-color
Closed

chore: remove unused github.com/fatih/color#1875
alexandear wants to merge 2 commits into
github:mainfrom
alexandear-org:chore/remove-fatih-color

Conversation

@alexandear

@alexandearalexandear commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the unused github.com/fatih/color dependency.

Why

The fatih/color package was unused in the codebase. This can be detected via go mod tidy. To prevent future regressions, this step was added in place of go mod download. Additionally, a workaround is needed on Windows to handle CRLF line endings that cause go mod tidy -diff to fail during CI runs.

What changed

  • Removed github.com/fatih/color from go.mod and go.sum
  • Cleaned up transitive dependencies that were only pulled in by fatih/color
  • Changed CI workflow from go mod download to go mod tidy -diff for better dependency validation
  • Added a pre-checkout step on Windows to configure Git to use LF line endings

MCP impact

  • No tool or API changes
  • Tool schema or behavior changed
  • New tool added

Prompts tested (tool changes only)

  • N/A

Security / limits

  • No security or limits impact
  • Auth / permissions considered
  • Data exposure, filtering, or token/size limits considered

Tool renaming

  • I am renaming tools as part of this PR (e.g. a part of a consolidation effort)
    • I have added the new tool aliases in deprecated_tool_aliases.go
  • I am not renaming tools as part of this PR

Lint & tests

  • Linted locally with ./script/lint
  • [] Tested locally with ./script/test

Docs

  • Not needed
  • Updated (README / docs / examples)

@alexandear
alexandear requested a review from a team as a code ownerJanuary 23, 2026 12:00
CopilotAI review requested due to automatic review settings January 23, 2026 12:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused github.com/fatih/color dependency and improves CI validation by enforcing clean module files.

Changes:

  • Removed unused github.com/fatih/color dependency and its transitive dependencies (mattn/go-colorable, mattn/go-isatty)
  • Updated CI workflow to validate module file cleanliness with go mod tidy -diff instead of just downloading dependencies

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

FileDescription
go.modRemoved github.com/fatih/color from require block and reflowed indirect dependencies alphabetically
go.sumRemoved checksums for fatih/color, mattn/go-colorable, mattn/go-isatty, and related golang.org/x/sys entries
.github/workflows/go.ymlChanged CI step from go mod download to go mod tidy -diff to enforce module file discipline

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

go.mod:14

  • According to the project's coding guidelines, when dependencies are changed, you should run script/licenses to update the third-party license files. Please verify that script/licenses has been run and commit any changes to the third-party-licenses.*.md files if they were updated. This ensures license compliance is maintained.
go 1.24.0
require (
github.com/google/go-github/v79 v79.0.0
github.com/google/jsonschema-go v0.4.2
github.com/josephburnett/jd v1.9.2
github.com/microcosm-cc/bluemonday v1.0.27
github.com/muesli/cache2go v0.0.0-20221011235721-518229cd8021
github.com/spf13/cobra v1.10.2
github.com/spf13/viper v1.21.0
github.com/stretchr/testify v1.11.1
)

@SamMorrowDrumsSamMorrowDrums left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great catch! Appreciate the diligent PRs.

@SamMorrowDrums

Copy link
Copy Markdown
Collaborator

Closing in favor of #1892 which rebases your commits onto main. Your authorship has been preserved - thank you for the contribution! 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandear@SamMorrowDrums