Skip to content

Add ability to view branches for a repo #141 - #205

Merged
juruen merged 10 commits into
github:mainfrom
aryasoni98:issues-141
Apr 11, 2025
Merged

Add ability to view branches for a repo #141#205
juruen merged 10 commits into
github:mainfrom
aryasoni98:issues-141

Conversation

@aryasoni98

@aryasoni98aryasoni98 commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

Closes: #141

@aryasoni98

aryasoni98 commented Apr 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Hi @juruen,
Whenever you get a chance, could you please review the PR? Let me know if anything needs to be updated. Appreciate your time!

alexvettithanam-gep

This comment was marked as spam.

Sign in to view

@SamMorrowDrums

SamMorrowDrums commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

This looks great thank you, I just merged a PR that will require some small updates to this one: #195

@aryasoni98

aryasoni98 commented Apr 10, 2025

Copy link
Copy Markdown
ContributorAuthor

This looks great thank you, I just merged a PR that will require some small updates to this one: #195

Thanks for the heads-up! Just to clarify — could you please specify what small changes are needed following the merge of #195?
Also, I noticed the conflict in pkg/github/server.go — would resolving that be part of the required updates?

juruen
juruen requested changes Apr 10, 2025
View reviewed changes

@juruenjuruen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a little comment about making the test code more consistent with the existing code base.

Comment threadpkg/github/repositories_test.go
@aryasoni98
aryasoni98 requested a review from juruenApril 10, 2025 18:43
juruen
juruen requested changes Apr 11, 2025
View reviewed changes

@juruenjuruen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are almost there! There's just a few lint errors that need to be fixed: we need to make sure we use github.Ptr and not the deprecated versions.

@aryasoni98

aryasoni98 commented Apr 11, 2025

Copy link
Copy Markdown
ContributorAuthor

We are almost there! There's just a few lint errors that need to be fixed: we need to make sure we use github.Ptr and not the deprecated versions.

@juruen Update the code. Please review the PR .

juruen
juruen approved these changes Apr 11, 2025
View reviewed changes

@juruenjuruen left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aryasoni98 I almost forget, we need to update the README file with the new tool! 🙇

juruen
juruen requested changes Apr 11, 2025
View reviewed changes

@juruenjuruen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we are just missing updating the README with the new tool

@aryasoni98
aryasoni98 requested a review from juruenApril 11, 2025 12:17
@aryasoni98

aryasoni98 commented Apr 11, 2025

Copy link
Copy Markdown
ContributorAuthor

I believe we are just missing updating the README with the new tool

@juruen Update the README.md file

juruen
juruen approved these changes Apr 11, 2025
View reviewed changes

@juruenjuruen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Thank you so much for your contribution!

@juruen
juruen merged commit 01aefd3 into github:mainApr 11, 2025
@williammartinwilliammartin mentioned this pull request Apr 11, 2025
Closed
nickytonline pushed a commit to nickytonline/github-mcp-http that referenced this pull request Oct 4, 2025
@aryasoni98
Add ability to view branches for a repogithub#141(github#205)
ff0f853
* Add ability to view branches for a repo github#141
* fix: update ListBranches test to use InputSchema and correct translation helper
* fix: update ListBranches test to use InputSchema and correct translation helper
* fix: update ListBranches test to handle errors in tool result
* fix: replace deprecated github.String with github.Ptr
* docs: add list_branches tool documentation to README
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juruenjuruenjuruen approved these changes
@SamMorrowDrumsSamMorrowDrumsAwaiting requested review from SamMorrowDrums
@williammartinwilliammartinAwaiting requested review from williammartin
@tobytobyAwaiting requested review from toby
@alexvettithanam-gepalexvettithanam-gepAwaiting requested review from alexvettithanam-gep

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ability to view "branches" for a repo

4 participants

@aryasoni98@SamMorrowDrums@juruen@alexvettithanam-gep