Uh oh!
There was an error while loading. Please reload this page.
fix: clarify pending review creation - #2569
Conversation
1f952ed to
5a97566Comparehe-yufeng
commented
May 29, 2026
Rebased the branch onto current Validation after rebase:
|
SamMorrowDrums
left a comment
There was a problem hiding this comment.
Targeted fix for #2524 — makes it clear that create without event produces a pending review, and refreshes the description to cover all five methods (including resolve_thread/unresolve_thread). README and toolsnap are updated consistently.
Minor nit: the user-facing Title annotation still doesn't mention thread resolve/unresolve, while the description does. Could broaden in a follow-up (e.g. "Manage pull request reviews and review threads"), not blocking. LGTM.
133347f to
cc3f9b9Comparehe-yufeng
commented
Jun 4, 2026
Rebased this approved branch onto current Validation after rebase:
The PR diff remains limited to |
cc3f9b9 to
1101a48Comparehe-yufeng
commented
Jun 4, 2026
Rebased this approved branch onto latest Validation after rebase: |
1101a48 to
5cb469bComparehe-yufeng
commented
Jun 6, 2026
Rebased this approved branch onto current Validation after rebase: |
a988a47 to
6ab4dadCompare6ab4dad to
b2bf8bbComparehe-yufeng
commented
Jul 11, 2026
Friendly nudge: this has been approved since May 30 and I've kept the branch current with main since. Happy to adjust anything if the review picture has changed. |
Summary
pull_request_review_writetitle say thatcreateopens a pending reviewmethod: "create"withouteventdoes not submit the reviewFixes#2524.
To verify
UPDATE_TOOLSNAPS=true go test ./pkg/github -run TestCreateAndSubmitPullRequestReview -count=1go test ./pkg/github -run TestCreateAndSubmitPullRequestReview -count=1go test ./pkg/github -count=1go test ./...git diff --check