Uh oh!
There was an error while loading. Please reload this page.
fix: hide write UI resources in read-only mode - #2581
Closed
he-yufeng wants to merge 1 commit into
Closed
Conversation
he-yufeng
commented
May 31, 2026
ContributorAuthor
Validated the current branch locally after closing the superseded #2574: |
he-yufengforce-pushed
the
fix/read-only-ui-resources-v3
branch
from
May 31, 2026 19:37
09ccbeb to
b8743edComparehe-yufeng
commented
May 31, 2026
ContributorAuthor
Rebased on current Validation:
|
he-yufengforce-pushed
the
fix/read-only-ui-resources-v3
branch
from
June 2, 2026 19:39
b8743ed to
f8934bdComparehe-yufeng
commented
Jun 2, 2026
ContributorAuthor
Rebased on current Validated: gofmt -w $(git diff --name-only origin/main...HEAD |Where-Object { $_-like'*.go' })
go test ./pkg/github -run UIResources
go test ./pkg/github
git diff --check origin/main...HEADAll passed after the rebase. |
he-yufeng
commented
Jun 6, 2026
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_me_uiresource availableissue_write_uiandpr_write_uiwhen write tools are filtered by--read-onlyFixes#2519.
To verify
go test ./pkg/github -run "TestRegisterUIResources_ReadOnlySkipsWriteResources|TestRegisterUIResources_ReadableViaClient|TestNewMCPServer_RegistersUIResources" -count=1go test ./pkg/github -count=1git diff --check