Skip to content

Fix IFC private repository labels - #2695

Merged
RossTarrant merged 4 commits into
mainfrom
rosstarrant/fix-ifc-private-labels
Jun 17, 2026
Merged

Fix IFC private repository labels#2695
RossTarrant merged 4 commits into
mainfrom
rosstarrant/fix-ifc-private-labels

Conversation

@RossTarrant

Copy link
Copy Markdown
Contributor

Summary

  • classify private repository issue/list/search results as private-trusted instead of private-untrusted
  • update search-related IFC comments and expectations for joined private results
  • add focused IFC unit coverage for list/search issue labels

Tests

  • script/lint && script/test
  • go test -race ./pkg/ifc ./pkg/github

CopilotAI review requested due to automatic review settings June 15, 2026 15:24
@RossTarrant
RossTarrant requested a review from a team as a code ownerJune 15, 2026 15:24

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the IFC (Information Flow Control) labeling behavior for issue list/search (and other multi-repo search-style outputs) so that private repository results are labeled private-trusted rather than private-untrusted, and adjusts related documentation/comments plus unit tests accordingly.

Changes:

  • Update pkg/ifc label helpers to return PrivateTrusted() for private issue list/search results.
  • Refresh IFC-related comments in search/list code paths to reflect the new private-trusted semantics.
  • Add/adjust unit tests to assert the updated IFC integrity/confidentiality expectations.
Show a summary per file
FileDescription
pkg/ifc/ifc.goChanges private issue list/search label functions to return PrivateTrusted() and updates associated IFC join documentation.
pkg/ifc/ifc_test.goAdds focused unit coverage for list/search label integrity/confidentiality outcomes.
pkg/github/search.goUpdates inline comments describing IFC joining behavior for repository/code/commit searches.
pkg/github/search_test.goUpdates IFC insiders-mode expectations for search_repositories when private repos are present.
pkg/github/repositories.goUpdates inline comments for joined IFC labeling in starred-repo listing.
pkg/github/issues_test.goUpdates IFC insiders-mode expectations for issue read/search/list flows involving private repositories.

Copilot's findings

  • Files reviewed: 6/6 changed files
  • Comments generated: 7

Comment threadpkg/ifc/ifc.go
Comment threadpkg/ifc/ifc.go
Comment threadpkg/ifc/ifc_test.go Outdated
Comment threadpkg/github/search_test.go
Comment threadpkg/github/issues_test.go Outdated
Comment threadpkg/github/issues_test.go
Comment threadpkg/github/issues_test.go
@RossTarrant
RossTarrantforce-pushed the rosstarrant/fix-ifc-private-labels branch from 782c706 to c34ff37CompareJune 15, 2026 16:03
Comment threadpkg/ifc/ifc.go Outdated
@RossTarrant
RossTarrantforce-pushed the rosstarrant/fix-ifc-private-labels branch 3 times, most recently from 301f5b5 to 8a869f0CompareJune 16, 2026 13:40
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@RossTarrant
RossTarrantforce-pushed the rosstarrant/fix-ifc-private-labels branch from 8a869f0 to f92f8a7CompareJune 16, 2026 13:41
Comment threadpkg/ifc/ifc.go
Comment threadpkg/github/projects.go Outdated
return visibilities
}

func attachProjectVisibilityIFCLabel(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move attachProjectVisibilityIFCLabel to ifc.go? We can fetch isPrivate and pass it to the function

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@RossTarrant@JoannaaKL@CZNetworks