Uh oh!
There was an error while loading. Please reload this page.
Add missing enum constraints - #278
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing enum constraints for various string properties to ensure only the allowed values are accepted.
- Enforced enum constraints for pull request state, sort options, merge methods, and review event types in pkg/github/pullrequests.go.
- Added enum constraints for code scanning alert states and severity levels in pkg/github/code_scanning.go.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/pullrequests.go | Added enum constraints for pull request query and review parameters. |
| pkg/github/code_scanning.go | Added enum constraints for code scanning alerts parameters. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
2928235 to
a92e445Comparef810b65 to
5a7d13cCompareUh oh!
There was an error while loading. Please reload this page.
SamMorrowDrums
left a comment
There was a problem hiding this comment.
Added one minor suggestion (the word category doesn't add much I think) but it's a nit, and this looks great. Thanks for all your work on finding all these!
* Add missing enum constraints * Remove redundant listing of additional enums in descriptions --------- Co-authored-by: Sam Morrow <info@sam-morrow.com>
Use config to mount kubernetes .kube/config
This pr adds some missing enum constraints for string props with enum like categories.
It also removes those listed enums from the descriptions, as the llm already receives the list of possible candidates by the the enum constraint.
This will save tokens as noted by @SamMorrowDrums
In regard to #228
Example testing with Copilot(Model Claude 3.7 Sonnet):