Skip to content

Adding SecretScanning Toolset - #280

Merged
SamMorrowDrums merged 9 commits into
mainfrom
tonytrg/add-secret-scanning-tools
Apr 17, 2025
Merged

Adding SecretScanning Toolset#280
SamMorrowDrums merged 9 commits into
mainfrom
tonytrg/add-secret-scanning-tools

Conversation

@tonytrg

@tonytrgtonytrg commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

This PR adds:

@tonytrg
tonytrgforce-pushed the tonytrg/add-secret-scanning-tools branch from d31dd8b to 6c01bf9CompareApril 16, 2025 14:15
@tonytrg
tonytrg marked this pull request as ready for review April 16, 2025 14:22
CopilotAI review requested due to automatic review settings April 16, 2025 14:22

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new secret scanning toolset to the MCP server by adding two new commands: GetSecretScanningAlert and ListSecretScanningAlerts.

  • Integrates secret scanning tools into the toolset initialization in pkg/github/tools.go.
  • Implements secret scanning functionalities in pkg/github/secret_scanning.go with accompanying tests in pkg/github/secret_scanning_test.go.
  • Updates the README.md with usage documentation for the new secret scanning endpoints.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

FileDescription
pkg/github/tools.goRegisters the secret scanning tools into the toolset collection.
pkg/github/secret_scanning_test.goProvides tests ensuring correct behavior of the secret scanning tool handlers.
pkg/github/secret_scanning.goImplements the GetSecretScanningAlert and ListSecretScanningAlerts functions.
README.mdAdds documentation detailing the usage of the new secret scanning tools.

Comment threadREADME.md Outdated
@tonytrgtonytrg changed the title Adding GetSecretScanningAlert and ListSecretScanningAlertsAdding SecretScanning ToolsetApr 16, 2025
@tonytrg

tonytrg commented Apr 16, 2025

Copy link
Copy Markdown
ContributorAuthor

Did a manual test run:

Can you list me all secret scanning alerts in github/repo that are resolved?
A: Query params
{
"owner": "github",
"repo": "repo",
"state": "resolved"
}
[
... Returned list of secretalerts, all resolved
]
Alright give me github/repo alertnumber 196
A:
Query params
{
"owner": "github",
"repo": "repo",
"alertNumber": 196
}
{"number":196,
...
}

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@tonytrgtonytrg self-assigned this Apr 16, 2025

@SamMorrowDrumsSamMorrowDrums left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great, just a couple of small comments.

Comment thread.gitignore Outdated
Comment threadpkg/github/tools.go Outdated
tonytrgand others added 3 commits April 17, 2025 10:11
Co-authored-by: Sam Morrow <info@sam-morrow.com>
…/github-mcp-server into tonytrg/add-secret-scanning-tools
@tonytrg

Copy link
Copy Markdown
ContributorAuthor

@SamMorrowDrums good eye for product names.

@SamMorrowDrumsSamMorrowDrums left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Tony!

@SamMorrowDrums
SamMorrowDrums merged commit 7c197f5 into mainApr 17, 2025
@SamMorrowDrums
SamMorrowDrums deleted the tonytrg/add-secret-scanning-tools branch April 17, 2025 08:20
nickytonline pushed a commit to nickytonline/github-mcp-http that referenced this pull request Oct 4, 2025
* Adding GetSecretScanningAlert and ListSecretScanningAlerts
* adding wip for tests
* fix tests
* add readme section
* Update README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update .gitignore
Co-authored-by: Sam Morrow <info@sam-morrow.com>
* fix product name
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Sam Morrow <info@sam-morrow.com>
DaleSeo pushed a commit to DaleSeo/github-mcp-server that referenced this pull request Oct 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tonytrg@SamMorrowDrums