Uh oh!
There was an error while loading. Please reload this page.
Adding SecretScanning Toolset - #280
Merged
Merged
Conversation
tonytrgforce-pushed
the
tonytrg/add-secret-scanning-tools
branch
from
April 16, 2025 14:15
d31dd8b to
6c01bf9Comparetonytrg
marked this pull request as ready for review
April 16, 2025 14:22
tonytrg
requested review from
SamMorrowDrums, juruen, toby and williammartin
as code ownersApril 16, 2025 14:22
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new secret scanning toolset to the MCP server by adding two new commands: GetSecretScanningAlert and ListSecretScanningAlerts.
- Integrates secret scanning tools into the toolset initialization in pkg/github/tools.go.
- Implements secret scanning functionalities in pkg/github/secret_scanning.go with accompanying tests in pkg/github/secret_scanning_test.go.
- Updates the README.md with usage documentation for the new secret scanning endpoints.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/github/tools.go | Registers the secret scanning tools into the toolset collection. |
| pkg/github/secret_scanning_test.go | Provides tests ensuring correct behavior of the secret scanning tool handlers. |
| pkg/github/secret_scanning.go | Implements the GetSecretScanningAlert and ListSecretScanningAlerts functions. |
| README.md | Adds documentation detailing the usage of the new secret scanning tools. |
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
Did a manual test run: |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SamMorrowDrums
left a comment
Collaborator
There was a problem hiding this comment.
I think this looks great, just a couple of small comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Sam Morrow <info@sam-morrow.com>
…/github-mcp-server into tonytrg/add-secret-scanning-tools
tonytrg
commented
Apr 17, 2025
ContributorAuthor
@SamMorrowDrums good eye for product names. |
nickytonline pushed a commit
to nickytonline/github-mcp-http
that referenced
this pull request
Oct 4, 2025
* Adding GetSecretScanningAlert and ListSecretScanningAlerts * adding wip for tests * fix tests * add readme section * Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .gitignore Co-authored-by: Sam Morrow <info@sam-morrow.com> * fix product name --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Sam Morrow <info@sam-morrow.com>
DaleSeo pushed a commit
to DaleSeo/github-mcp-server
that referenced
this pull request
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds: