Uh oh!
There was an error while loading. Please reload this page.
assert request params in code_scanning_test - #94
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the code scanning alerts test to assert that the expected query parameters are included in the GitHub API request.
- Replaces mock.WithRequestMatch with mock.WithRequestMatchHandler to allow for more flexible request matching.
- Introduces the expectQueryParams helper to assert that parameters "ref", "state", and "severity" are correctly set.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This makes use of the new helper functionality to assert the right code scanning parameters are passed to the GH API request.