Uh oh!
There was an error while loading. Please reload this page.
assert params and body in repositories_test - #96
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances test coverage in the repository tests by asserting that request parameters and request bodies are correctly handled.
- Replaces mock.WithRequestMatch with mock.WithRequestMatchHandler across multiple test cases.
- Introduces explicit assertions for query parameters and request bodies in tests.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
juruen
marked this pull request as draft
April 4, 2025 10:33
juruenforce-pushed
the
juruen/repository-test
branch
2 times, most recently
from
April 4, 2025 10:38
cc1bc67 to
ae4cbd0Comparejuruen
marked this pull request as ready for review
April 4, 2025 10:49
SamMorrowDrums
approved these changes
Apr 4, 2025
juruenforce-pushed
the
juruen/repository-test
branch
from
April 4, 2025 11:58
ae4cbd0 to
5c5f42fComparewilliammartin
approved these changes
Apr 4, 2025
DaleSeo pushed a commit
to DaleSeo/github-mcp-server
that referenced
this pull request
Oct 24, 2025
* Add SmartBear MCP * rename to smartbear * update secrets * Add insight hub api key configuration * amend name * Update servers/smartbear/server.yaml Co-authored-by: Tom Longridge <tom.longridge@smartbear.com> * fix server yaml to correct initialization --------- Co-authored-by: Tom Longridge <tom.longridge@smartbear.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follow-up PR to #95 to continue improving our test coverage. These changes assert that the request parameters and body are correctly handled in the
repositories_testfile.