Uh oh!
There was an error while loading. Please reload this page.
Anchor MANIFEST to repo root to avoid matching subdirectories - #4890
Open
mahyarmirrashed wants to merge 1 commit into
Open
Anchor MANIFEST to repo root to avoid matching subdirectories#4890mahyarmirrashed wants to merge 1 commit into
mahyarmirrashed wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to the application or project's homepage
N/A
Reasons for making this change
MANIFESTon it's own matches files and directories named "manifest" (case-insensitive) in the entire project. However,/MANIFESTmatches for only the root, which is where 99% of allMANIFESTfiles that are being targeted by this rule are living. Therefore, I see this as an improvement.Links to documentation supporting these rule changes
N/A
Merge and Approval Steps