Uh oh!
There was an error while loading. Please reload this page.
fixes eventToHotkeyString returns doubled "modifier" when "key" is a modifier - #64
Merged
Conversation
theinterned
commented
Dec 16, 2021
Comment on lines
+222
to
+223
| ['Control+Shift', {ctrlKey: true, shiftKey: true, key: 'Shift'}], | ||
| ['Control+Shift', {ctrlKey: true, shiftKey: true, key: 'Control'}] |
ContributorAuthor
There was a problem hiding this comment.
These were initially failing with:
FAILED TESTS:
hotkey
eventToHotkeyString
✖ {"ctrlKey":true,"shiftKey":true,"key":"Shift"} => Control+Shift
Chrome Headless 96.0.4664.110 (Mac OS 10.15.7)
Error: Uncaught AssertionError: expected 'Control+Shift+Shift' to equal 'Control+Shift' (node_modules/chai/chai.js:250)
at Context.<anonymous> (test/test.js:232:23)
✖ {"ctrlKey":true,"shiftKey":true,"key":"Control"} => Control+Shift
Chrome Headless 96.0.4664.110 (Mac OS 10.15.7)
Error: Uncaught AssertionError: expected 'Control+Shift+Control' to equal 'Control+Shift' (node_modules/chai/chai.js:250)
at Context.<anonymous> (test/test.js:232:23)theinterned
commented
Dec 16, 2021
ContributorAuthor
I wonder if you reviewers would consider this a breaking change? It is arguably as the format of the string does change. |
keithamus
approved these changes
Dec 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves#60
This PR fixes a bug where
eventToHotkeyStringwas returning a "double modifier" for a key-combination where a modifier key (Control,Alt,Meta, orShift) is also theevent.key.This PR updates
eventToHotkeyStringso that the resulting string still presents modifiers in a consistent order.For more details see #60
Screencast of the after
Screen.Recording.2021-12-16.at.5.59.41.PM.mov
Breaking change
Although the previous behaviour was likely a bug, this is a breaking change in that it changes the "hotkey string" format when a modifier key is used as the
hotkey(the final element in a hotkey string sequence) for exampleMeta+Shift+ShiftbecomesMeta+Shiftafter this change.