Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 192
feat: expose part=root for external CSS targeting#341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f14f195
feat: add part="text" to shadow DOM span for external CSS targeting
silverwind 441b46f
docs: add part="text" styling section to README and test for aria-hid…
silverwind 08cd402
add example
silverwind c82932a
feat: rename part="text" to part="root"
silverwind e14fff4
update docs
silverwind 9b987de
Merge branch 'main' into part
siddharthkp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -2122,7 +2122,6 @@ suite('relative-time', function () { | ||
| await Promise.resolve() | ||
| assert.isNull(time.shadowRoot.querySelector('[aria-hidden]'), 'Expected no aria-hidden to be present') | ||
| assert.isNull(time.shadowRoot.querySelector('span'), 'Expected no span to be present') | ||
| }) | ||
| test('no aria-hidden applies to shadow root', async () => { | ||
| @@ -2132,7 +2131,30 @@ suite('relative-time', function () { | ||
| await Promise.resolve() | ||
| assert.isNull(time.shadowRoot.querySelector('[aria-hidden]'), 'Expected no aria-hidden to be present') | ||
| assert.isNull(time.shadowRoot.querySelector('span'), 'Expected no span to be present') | ||
| }) | ||
| }) | ||
| suite('[part]', () => { | ||
| test('shadow root span has part="root"', async () => { | ||
| const now = new Date().toISOString() | ||
| const time = document.createElement('relative-time') | ||
| time.setAttribute('datetime', now) | ||
| await Promise.resolve() | ||
| const span = time.shadowRoot.querySelector('span') | ||
| assert.equal(span.getAttribute('part'), 'root') | ||
| }) | ||
| test('shadow root span has part="root" alongside aria-hidden="true"', async () => { | ||
| const now = new Date().toISOString() | ||
| const time = document.createElement('relative-time') | ||
| time.setAttribute('datetime', now) | ||
| time.setAttribute('aria-hidden', 'true') | ||
| await Promise.resolve() | ||
| const span = time.shadowRoot.querySelector('span') | ||
| assert.equal(span.getAttribute('part'), 'root') | ||
| assert.equal(span.getAttribute('aria-hidden'), 'true') | ||
| }) | ||
| }) | ||
silverwind marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.