Skip to content

Replace custom RailsApplicationRecord and RailsRenderInline cops with their upstream equivalent#123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bensheldon merged 3 commits into from
Oct 26, 2022
Merged

Replace custom RailsApplicationRecord and RailsRenderInline cops with their upstream equivalent #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce23317
Replace custom `RailsApplicationRecord` and `RailsRenderInline` cops …
bensheldon Oct 13, 2022
cd76ecf
Merge branch 'main' into remove-upstream-dupes
bensheldon Oct 26, 2022
fb20774
Merge branch 'main' into remove-upstream-dupes
bensheldon Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions config/rails.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,6 @@ require:
- rubocop-github-rails
- rubocop-rails

GitHub/RailsApplicationRecord:
Enabled: true

GitHub/RailsControllerRenderActionSymbol:
Enabled: true

Expand All@@ -17,9 +14,6 @@ GitHub/RailsControllerRenderPathsExist:
GitHub/RailsControllerRenderShorthand:
Enabled: true

GitHub/RailsRenderInline:
Enabled: true

GitHub/RailsRenderObjectCollection:
Enabled: false

Expand DownExpand Up@@ -94,7 +88,7 @@ Rails/ApplicationMailer:
Enabled: false

Rails/ApplicationRecord:
Enabled: false
Enabled: true

Rails/ArelStar:
Enabled: false
Expand DownExpand Up@@ -307,7 +301,7 @@ Rails/RelativeDateConstant:
Enabled: false

Rails/RenderInline:
Enabled: false
Enabled: true

Rails/RenderPlainText:
Enabled: false
Expand Down
3 changes: 0 additions & 3 deletions config/rails_cops.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
GitHub/RailsApplicationRecord:
Enabled: pending

GitHub/RailsControllerRenderActionSymbol:
Enabled: pending
Include:
Expand Down
27 changes: 0 additions & 27 deletions guides/rails-render-inline.md
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions lib/rubocop/cop/github/rails_application_record.rb
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions lib/rubocop/cop/github/rails_render_inline.rb
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions test/test_rails_application_record.rb
View file
Open in desktop

This file was deleted.

62 changes: 0 additions & 62 deletions test/test_rails_render_inline.rb
View file
Open in desktop

This file was deleted.