Uh oh!
There was an error while loading. Please reload this page.
config/default: Link some rules to their styleguide justifications - #124
Merged
Conversation
issyl0
commented
Oct 18, 2022
Member
- "Some of", yes, since there are a lot. But I thought I'd get started since this is an important step towards being able to a) enable more RuboCop rules based on the evidence of our styleguide, b) realising how far adrift our RuboCop configs have potentially become from what's written in the Styleguide, c) encouraging honest adoption of these rules across GitHub because they're actually justified in text.
elenatanasoiu
approved these changes
Oct 19, 2022
- "Some of", yes, since there are a lot. But I thought I'd get started since this is an important step towards being able to a) enable more RuboCop rules based on the evidence of our styleguide, b) realising how far adrift our RuboCop configs have potentially become from what's written in the Styleguide, c) encouraging honest adoption of these rules across GitHub because they're actually justified in text.
issyl0force-pushed
the
match-styleguide-to-rubocop
branch
from
October 19, 2022 10:59
784120d to
596f143Comparesampart
reviewed
Oct 20, 2022
sampart
left a comment
Contributor
There was a problem hiding this comment.
Thanks so much for doing this. One retrospective comment.
| # TODO: Enable this since it's in the styleguide. | ||
| Lint/UnusedBlockArgument: | ||
| Enabled: false | ||
| StyleGuide: https://github.com/github/rubocop-github/blob/main/STYLEGUIDE.md#spaces-around-equals |
Contributor
There was a problem hiding this comment.
MemberAuthor
There was a problem hiding this comment.
Oops, yes it should! Feel free to submit a PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.