Skip to content

Update default.yml to enable case indentation - #143

Merged
jcmanzo merged 3 commits into
mainfrom
jcmanzo-patch-1
Jan 3, 2024
Merged

Update default.yml to enable case indentation#143
jcmanzo merged 3 commits into
mainfrom
jcmanzo-patch-1

Conversation

@jcmanzo

@jcmanzojcmanzo commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

Hello, I noticed that the styleguide suggests a case indentation rule that is not being enforced by the rubocop config. Is it safe to enable this?

@jcmanzo
jcmanzo requested a review from a team as a code ownerNovember 7, 2023 17:33
@jcmanzo

Copy link
Copy Markdown
ContributorAuthor

Hi @github/rubocop-reviewers 👋

Could I please get some eyes on this change? 🙏 Is this something that would be ok to go out?

@issyl0

Copy link
Copy Markdown
Member

Hey, sorry for the delay here. Thanks for the PR. Looking now!

@issyl0issyl0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment threadconfig/default.yml
Co-authored-by: Issy Long <issyl0@github.com>
@jcmanzo
jcmanzo merged commit 4046c80 into mainJan 3, 2024
@jcmanzo
jcmanzo deleted the jcmanzo-patch-1 branch January 3, 2024 15:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jcmanzo@issyl0