Uh oh!
There was an error while loading. Please reload this page.
Update rubocop related dependencies - #72
Conversation
There was a problem hiding this comment.
How would you feel about removing the constraints on "rubocop-performance" and "rubocop-rails" as well? My general feeling is that version constraints in gems make upgrades more challenging and don't provide much value except in the case where there is a known conflict between versions.
cf02c88 to
e1cc488Comparecomposerinteralia
commented
Jul 20, 2020
Actually I might be wrong in this case. It looks like we are locking the version in this case so we can coordinate updating the gem with updating the yaml file (see e82e9b2 for example). Maybe we should bump to whatever the latest version is instead? |
HParker
commented
Jul 20, 2020
Ah, I suppose without that version lock CI might just start failing on an unrelated change. I'll update this to lock to latest versions of those 3 gems so that we can at least prevent these gems updating on unrelated changes here. |
Update version requirement on, - rubocop - rubocop-performance - rubocop-rails
e1cc488 to
ba58491Compare
composerinteralia
left a comment
There was a problem hiding this comment.
Yup, that makes sense. Thanks!
No description provided.