Skip to content

Use Cop::Base API - #87

Merged
composerinteralia merged 2 commits into
github:masterfrom
koic:use_cop_base_api
Jun 27, 2022
Merged

Use Cop::Base API#87
composerinteralia merged 2 commits into
github:masterfrom
koic:use_cop_base_api

Conversation

@koic

@koickoic commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

Follow rubocop/rubocop#7868.

The legacy Cop::Cop API is soft deprecated and this PR use new Cop::Base API instead.

maintain any RuboCop extensions, as the legacy API will be removed in
RuboCop 2.0.

https://metaredux.com/posts/2020/10/21/rubocop-1-0.html

This new API requires RuboCop 0.87 or higher.
https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#0870-2020-07-06

Denpendency version of s.add_dependency "rubocop" does not need to be updated in the gemspec if #86 has been merged first.

Follow rubocop/rubocop#7868.
The legacy `Cop::Cop` API is soft deprecated and this PR use
new `Cop::Base` API instead.
> maintain any RuboCop extensions, as the legacy API will be removed in
> RuboCop 2.0.
https://metaredux.com/posts/2020/10/21/rubocop-1-0.html
This new API requires RuboCop 0.87 or higher.
https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md#0870-2020-07-06
Denpendency version of `s.add_dependency "rubocop"` does not need to be
updated in the gemspec if github#86 has been merged first.
@koic
koicforce-pushed the use_cop_base_api branch from 54d65ef to 0bc4a31CompareJune 27, 2022 17:26
@composerinteralia

Copy link
Copy Markdown
Member

Thanks!

@composerinteralia
composerinteralia merged commit 3d1ad77 into github:masterJun 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@koic@composerinteralia