Uh oh!
There was an error while loading. Please reload this page.
Lowercase headers - #533
Conversation
obrie
commented
Nov 22, 2024
Thanks for working on this! It'd be great to have this merged and released to unblock local development with Rack 3.x. |
rzhade3
left a comment
There was a problem hiding this comment.
Thanks for this PR! This is a great change. Couple changes suggested below after which we can merge this PR in:
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
arashnd
commented
Dec 6, 2024
thanks! @rzhade3 |
All PRs:
Adding a new header
Generally, adding a new header is always OK.
Adding a new CSP directive
Rack 3
Response header keys can no longer include uppercase characters.https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md#rack-3-upgrade-guide
Rack Lint error out when using
secure_headersbecause its adding headers with uppercase