Skip to content

Add arm64 builds for macOS, and build them from GH Actions - #77

Open
sergiou87 wants to merge 3 commits into
github:mainfrom
sergiou87:darwin-arm64-support
Open

Add arm64 builds for macOS, and build them from GH Actions#77
sergiou87 wants to merge 3 commits into
github:mainfrom
sergiou87:darwin-arm64-support

Conversation

@sergiou87

@sergiou87sergiou87 commented Apr 27, 2021

Copy link
Copy Markdown
Member

Trying to get https://github.com/desktop/desktop builds for macOS arm64, we need to build git in https://github.com/desktop/dugite-native for arm64, and in order to do that we need smimesign built for arm64 😄

I hope this is enough to make it happen 🤞

Spoiler: it doesn't yet, I'll work on this 😂

After some work it seems Travis doesn't want to help me get those builds, so I directly migrated the macOS CI script to GitHub Actions.

I will probably do the same for Windows in a different PR, Soon™…

@sergiou87
sergiou87force-pushed the darwin-arm64-support branch from de93522 to ba50390CompareApril 27, 2021 10:32
@sergiou87sergiou87 changed the title Add arm64 builds for darwin[WIP] Add arm64 builds for darwinApr 27, 2021
@sergiou87
sergiou87force-pushed the darwin-arm64-support branch 2 times, most recently from e1b0b33 to 0574313CompareApril 27, 2021 17:49
@sergiou87
sergiou87force-pushed the darwin-arm64-support branch from 3dc813e to b0bebd9CompareApril 27, 2021 18:09
@sergiou87sergiou87 changed the title [WIP] Add arm64 builds for darwinAdd arm64 builds for macOS, and build them from GH ActionsApr 27, 2021

- name: Build
run: |
CGO_ENABLED=1 GOARCH=${{ matrix.arch }} GO111MODULE=on go build \

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding these two (CGO_ENABLED=1 GOARCH=${{ matrix.arch }}) is basically all I needed to get it building for arm64:

@lgarron

Copy link
Copy Markdown
Contributor

Thanks for this PR!

FYI, we've had to overhaul our build process for Actions. See #82

We don't currently have a permanent maintainer for smimesign, so we will probably avoid adding any builds for until we find such a maintainer (especially if the existing build still works, albeit unoptimized).
We also prefer for people to install on macOS using Homebrew, which automatically handles this.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sergiou87@lgarron