Support all types of field values, including all-digit single-select IDs

[maxdanilov]

Problem

A single select option id is an 8-character hexadecimal value (e.g. 47fc9ee4).
There's a 2.3% chance that this id will be comprised only of digits (e.g. 12345678): (10/16)^8 = 0.0232
If an option id is comprised of digits only, this action cannot set the field to this value.

Investigation Results

The underlying gh api graphql field update call is doing an automatic conversion of values that look like integers (source):

The -F/--field flag has magic type conversion based on the format of the value:

• literal values "true", "false", "null", and integer numbers get converted to appropriate JSON types;

It leads to this kind of error (98236657 in the example is an option ID (VALUE_TO_SET) passed in as -F value="$VALUE_TO_SET":

gh: Variable $value of type String was provided invalid value

{
"errors": [
{
"extensions": {
"value": 98236657,
"problems": [
{
"path": [],
"explanation": "Could not coerce value 98236657 to String"
}
]
},
"locations": [
{
"line": 1,
"column": 50
}
],
"message": "Variable $value of type String was provided invalid value"
}
]
}

Solution

Switching from direct value passing to reading the value from stdin since it bypasses the conversion and treats the passed value as a string.

[maxdanilov]

@benbalter what do you think about this proposal?

[maxdanilov]

@benbalter could you review this one, please?

[benbalter]

I'm currently on leave. Your proposal is great, but given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests, etc. If I have the chance to review your PR, I will, if not, I look forward to reviewing it when I am back from leave. Thanks for the contribution!

[benbalter]

given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests

Work in progress over in #11, but we can merge this PR In the interim. Thanks again!

[maxdanilov]

Problem

A single select option id is an 8-character hexadecimal value (e.g. 47fc9ee4).
There's a 2.3% chance that this id will be comprised only of digits (e.g. 12345678): (10/16)^8 = 0.0232
If an option id is comprised of digits only, this action cannot set the field to this value.

Investigation Results

The underlying gh api graphql field update call is doing an automatic conversion of values that look like integers (source):

The -F/--field flag has magic type conversion based on the format of the value:

• literal values "true", "false", "null", and integer numbers get converted to appropriate JSON types;

It leads to this kind of error (98236657 in the example is an option ID (VALUE_TO_SET) passed in as -F value="$VALUE_TO_SET":

gh: Variable $value of type String was provided invalid value

{
"errors": [
{
"extensions": {
"value": 98236657,
"problems": [
{
"path": [],
"explanation": "Could not coerce value 98236657 to String"
}
]
},
"locations": [
{
"line": 1,
"column": 50
}
],
"message": "Variable $value of type String was provided invalid value"
}
]
}

Solution

Switching from direct value passing to reading the value from stdin since it bypasses the conversion and treats the passed value as a string.

[maxdanilov]

@benbalter what do you think about this proposal?

[maxdanilov]

@benbalter could you review this one, please?

[benbalter]

I'm currently on leave. Your proposal is great, but given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests, etc. If I have the chance to review your PR, I will, if not, I look forward to reviewing it when I am back from leave. Thanks for the contribution!

[benbalter]

given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests

Work in progress over in #11, but we can merge this PR In the interim. Thanks again!

[maxdanilov]

Problem

A single select option id is an 8-character hexadecimal value (e.g. 47fc9ee4).
There's a 2.3% chance that this id will be comprised only of digits (e.g. 12345678): (10/16)^8 = 0.0232
If an option id is comprised of digits only, this action cannot set the field to this value.

Investigation Results

The underlying gh api graphql field update call is doing an automatic conversion of values that look like integers (source):

The -F/--field flag has magic type conversion based on the format of the value:

• literal values "true", "false", "null", and integer numbers get converted to appropriate JSON types;

It leads to this kind of error (98236657 in the example is an option ID (VALUE_TO_SET) passed in as -F value="$VALUE_TO_SET":

gh: Variable $value of type String was provided invalid value

{
"errors": [
{
"extensions": {
"value": 98236657,
"problems": [
{
"path": [],
"explanation": "Could not coerce value 98236657 to String"
}
]
},
"locations": [
{
"line": 1,
"column": 50
}
],
"message": "Variable $value of type String was provided invalid value"
}
]
}

Solution

Switching from direct value passing to reading the value from stdin since it bypasses the conversion and treats the passed value as a string.

[maxdanilov]

@benbalter what do you think about this proposal?

[maxdanilov]

@benbalter could you review this one, please?

[benbalter]

I'm currently on leave. Your proposal is great, but given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests, etc. If I have the chance to review your PR, I will, if not, I look forward to reviewing it when I am back from leave. Thanks for the contribution!

[benbalter]

given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests

Work in progress over in #11, but we can merge this PR In the interim. Thanks again!

[maxdanilov]

Problem

A single select option id is an 8-character hexadecimal value (e.g. 47fc9ee4).
There's a 2.3% chance that this id will be comprised only of digits (e.g. 12345678): (10/16)^8 = 0.0232
If an option id is comprised of digits only, this action cannot set the field to this value.

Investigation Results

The underlying gh api graphql field update call is doing an automatic conversion of values that look like integers (source):

The -F/--field flag has magic type conversion based on the format of the value:

• literal values "true", "false", "null", and integer numbers get converted to appropriate JSON types;

It leads to this kind of error (98236657 in the example is an option ID (VALUE_TO_SET) passed in as -F value="$VALUE_TO_SET":

gh: Variable $value of type String was provided invalid value

{
"errors": [
{
"extensions": {
"value": 98236657,
"problems": [
{
"path": [],
"explanation": "Could not coerce value 98236657 to String"
}
]
},
"locations": [
{
"line": 1,
"column": 50
}
],
"message": "Variable $value of type String was provided invalid value"
}
]
}

Solution

Switching from direct value passing to reading the value from stdin since it bypasses the conversion and treats the passed value as a string.

[maxdanilov]

@benbalter what do you think about this proposal?

[maxdanilov]

@benbalter could you review this one, please?

[benbalter]

I'm currently on leave. Your proposal is great, but given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests, etc. If I have the chance to review your PR, I will, if not, I look forward to reviewing it when I am back from leave. Thanks for the contribution!

[benbalter]

given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests

Work in progress over in #11, but we can merge this PR In the interim. Thanks again!

[maxdanilov]

Problem

A single select option id is an 8-character hexadecimal value (e.g. 47fc9ee4).
There's a 2.3% chance that this id will be comprised only of digits (e.g. 12345678): (10/16)^8 = 0.0232
If an option id is comprised of digits only, this action cannot set the field to this value.

Investigation Results

The underlying gh api graphql field update call is doing an automatic conversion of values that look like integers (source):

The -F/--field flag has magic type conversion based on the format of the value:

• literal values "true", "false", "null", and integer numbers get converted to appropriate JSON types;

It leads to this kind of error (98236657 in the example is an option ID (VALUE_TO_SET) passed in as -F value="$VALUE_TO_SET":

gh: Variable $value of type String was provided invalid value

{
"errors": [
{
"extensions": {
"value": 98236657,
"problems": [
{
"path": [],
"explanation": "Could not coerce value 98236657 to String"
}
]
},
"locations": [
{
"line": 1,
"column": 50
}
],
"message": "Variable $value of type String was provided invalid value"
}
]
}

Solution

Switching from direct value passing to reading the value from stdin since it bypasses the conversion and treats the passed value as a string.

[maxdanilov]

@benbalter what do you think about this proposal?

[maxdanilov]

@benbalter could you review this one, please?

[benbalter]

I'm currently on leave. Your proposal is great, but given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests, etc. If I have the chance to review your PR, I will, if not, I look forward to reviewing it when I am back from leave. Thanks for the contribution!

[benbalter]

given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests

Work in progress over in #11, but we can merge this PR In the interim. Thanks again!

[maxdanilov]

Problem

A single select option id is an 8-character hexadecimal value (e.g. 47fc9ee4).
There's a 2.3% chance that this id will be comprised only of digits (e.g. 12345678): (10/16)^8 = 0.0232
If an option id is comprised of digits only, this action cannot set the field to this value.

Investigation Results

The underlying gh api graphql field update call is doing an automatic conversion of values that look like integers (source):

The -F/--field flag has magic type conversion based on the format of the value:

• literal values "true", "false", "null", and integer numbers get converted to appropriate JSON types;

It leads to this kind of error (98236657 in the example is an option ID (VALUE_TO_SET) passed in as -F value="$VALUE_TO_SET":

gh: Variable $value of type String was provided invalid value

{
"errors": [
{
"extensions": {
"value": 98236657,
"problems": [
{
"path": [],
"explanation": "Could not coerce value 98236657 to String"
}
]
},
"locations": [
{
"line": 1,
"column": 50
}
],
"message": "Variable $value of type String was provided invalid value"
}
]
}

Solution

Switching from direct value passing to reading the value from stdin since it bypasses the conversion and treats the passed value as a string.

[maxdanilov]

@benbalter what do you think about this proposal?

[maxdanilov]

@benbalter could you review this one, please?

[benbalter]

I'm currently on leave. Your proposal is great, but given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests, etc. If I have the chance to review your PR, I will, if not, I look forward to reviewing it when I am back from leave. Thanks for the contribution!

[benbalter]

given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests

Work in progress over in #11, but we can merge this PR In the interim. Thanks again!

[maxdanilov]

Problem

A single select option id is an 8-character hexadecimal value (e.g. 47fc9ee4).
There's a 2.3% chance that this id will be comprised only of digits (e.g. 12345678): (10/16)^8 = 0.0232
If an option id is comprised of digits only, this action cannot set the field to this value.

Investigation Results

The underlying gh api graphql field update call is doing an automatic conversion of values that look like integers (source):

The -F/--field flag has magic type conversion based on the format of the value:

• literal values "true", "false", "null", and integer numbers get converted to appropriate JSON types;

It leads to this kind of error (98236657 in the example is an option ID (VALUE_TO_SET) passed in as -F value="$VALUE_TO_SET":

gh: Variable $value of type String was provided invalid value

{
"errors": [
{
"extensions": {
"value": 98236657,
"problems": [
{
"path": [],
"explanation": "Could not coerce value 98236657 to String"
}
]
},
"locations": [
{
"line": 1,
"column": 50
}
],
"message": "Variable $value of type String was provided invalid value"
}
]
}

Solution

Switching from direct value passing to reading the value from stdin since it bypasses the conversion and treats the passed value as a string.

[maxdanilov]

@benbalter what do you think about this proposal?

[maxdanilov]

@benbalter could you review this one, please?

[benbalter]

I'm currently on leave. Your proposal is great, but given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests, etc. If I have the chance to review your PR, I will, if not, I look forward to reviewing it when I am back from leave. Thanks for the contribution!

[benbalter]

given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests

Work in progress over in #11, but we can merge this PR In the interim. Thanks again!

[maxdanilov]

Problem

A single select option id is an 8-character hexadecimal value (e.g. 47fc9ee4).
There's a 2.3% chance that this id will be comprised only of digits (e.g. 12345678): (10/16)^8 = 0.0232
If an option id is comprised of digits only, this action cannot set the field to this value.

Investigation Results

The underlying gh api graphql field update call is doing an automatic conversion of values that look like integers (source):

The -F/--field flag has magic type conversion based on the format of the value:

• literal values "true", "false", "null", and integer numbers get converted to appropriate JSON types;

It leads to this kind of error (98236657 in the example is an option ID (VALUE_TO_SET) passed in as -F value="$VALUE_TO_SET":

gh: Variable $value of type String was provided invalid value

{
"errors": [
{
"extensions": {
"value": 98236657,
"problems": [
{
"path": [],
"explanation": "Could not coerce value 98236657 to String"
}
]
},
"locations": [
{
"line": 1,
"column": 50
}
],
"message": "Variable $value of type String was provided invalid value"
}
]
}

Solution

Switching from direct value passing to reading the value from stdin since it bypasses the conversion and treats the passed value as a string.

[maxdanilov]

@benbalter what do you think about this proposal?

[maxdanilov]

@benbalter could you review this one, please?

[benbalter]

I'm currently on leave. Your proposal is great, but given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests, etc. If I have the chance to review your PR, I will, if not, I look forward to reviewing it when I am back from leave. Thanks for the contribution!

[benbalter]

given the complexity, I might want to explore moving the logic to JS/TS so that we can add tests

Work in progress over in #11, but we can merge this PR In the interim. Thanks again!