Conversation
When reading old OLN files, ignore edge mask When writing OLN files don't save edge mask Fixed 2 locations where edge mask needs to be set to zero when checkbox is not checked in mirror dialog Fixed bug where edge mask is checked if not found in OLN file!
| } | ||
| } | ||
| else{ // just enable edge mask check box to use the current value. | ||
| md.changeEdgeMaskvalues(md.aperatureReduction); |
There was a problem hiding this comment.
So this line of code (line 2180 just above) is particularly nasty and found when reading OLN file: both the older V6 style OLN file and also when reading V7. It checks the "edge mask" checkbox even if nothing is found regarding edge mask in the OLN file!
Not only did I get rid of the above code in both "writeOLN" functions, I got rid of the entire function (which is where it checks the box in the gui). That function, changeEdgeMaskvalue(), was used in many places when reading OLN files but nowhere else. So I got rid of it.
gr5
commented
Nov 22, 2023
I spent a lot of time testing all the changes. It seems to work fine now. |
githubdoe
left a comment
There was a problem hiding this comment.
Thanks. Looks like it was pretty messed up with a lot of omissions. Makes me wonder what I was thinking. Guess I was distracted. Did not realize all the implications. Still puzzled why I did so much work in the reading and writing of it in the .oln file. That worries me that I thought it necessary. Now of course I think it was not.
gr5
commented
Nov 23, 2023
Dale, Do you want me to release 7.2 now just for this change? It's not too much trouble. I need to test the final release if I do a release it but I'll probably just do a few quick tests (load igram, process) as not much changed. And I already tested the changes. Although I will need to update the revision history and you'll need to approve that. |
githubdoe
commented
Nov 23, 2023
I think it would be nice but I will leave it up to you to decide based on your schedule and such. |
| @@ -2257,40 +2220,7 @@ void IgramArea::loadOutlineFileOldV6(QString fileName){ | |||
| mirrorDlg &md = *mirrorDlg::get_Instance(); | |||
There was a problem hiding this comment.
This line can be deleted as md is not used anymore. This will fix the [-Wunused-variable]
There was a problem hiding this comment.
oops. Already merged. Didn't see your comment until now.
There was a problem hiding this comment.
you can fix in the other PR. It's really minor.
This is how dead code comes to live 👻
atsju
commented
Nov 23, 2023
I wonder if this should be v7.1.2. This would be a pure bugfix release. |
When reading old OLN files, ignore edge mask
When writing OLN files don't save edge mask
Fixed 2 locations where edge mask needs to be set to zero when checkbox is not checked in mirror dialog Fixed bug where edge mask is checked if not found in OLN file!