Fix firewall log parser rejecting invalid domains from Squid error messages by Copilot · Pull Request #2330 · github/gh-aw

Copilot · 2025-10-24T22:20:04Z

Fix Blocked Domains Parsing and Display

This PR addresses the issue where the firewall log parser was showing invalid "domains" like "DNS", "Local", "Swap", "WARNING:", etc. in the blocked domains table.

Latest Changes

Recompiled workflows with updated firewall log parsing logic.

Code Review Fixes

✅ Improved domain regex to prevent consecutive dots, leading/trailing dots, and invalid label patterns
✅ Used arrow function syntax with parentheses for consistency
✅ Simplified loop using reduce for a more functional approach

Original Implementation

Strict field validation in parseFirewallLogLine:

Timestamp must be numeric with optional decimal: /^\d+(\.\d+)?$/
IP:port fields must match /^[\d.]+:\d+$/ or -
Domain must match strict pattern preventing invalid formats or -
Status must be numeric or -
Decision must contain : or -

Filter placeholder domains in summary:

constvalidDeniedDomains=deniedDomains.filter((domain)=>domain!=="-");constvalidDeniedRequests=validDeniedDomains.reduce((sum,domain)=>sum+(requestsByDomain.get(domain)?.denied||0),0);

UI enhancement:

Wrap blocked domains table in <details> tag for collapsibility
Change heading to <summary> with "click to expand" prompt

Domain Validation Examples

✅ Valid domains:

api.github.com:443
sub.example.com:443
my-domain.com:443

❌ Rejected invalid domains:

.example.com:443 (leading dot)
example.com.:443 (trailing dot)
example..com:443 (consecutive dots)
-example.com:443 (leading hyphen)
example.com-:443 (trailing hyphen in label)

Testing

✅ All 18 firewall log parsing tests passing
✅ All 595 JavaScript tests passing
✅ Validated strict domain regex with edge cases
✅ All workflows recompiled successfully

Original prompt

It looks like the filter for blocked domains are not precise enough. Looks like the run output https://github.com/githubnext/gh-aw/actions/runs/18793451386 which outputs
🚫 Blocked Domains
Domain Blocked Requests
- 3
Accepting 1
DNS 2
Local 1
Swap 1
WARNING: 1
Waiting 1
example.com:443 1
pinger
and this tells me that the only valid domain that is blocked is example.com. Could you please improve the parsing logic?
Also move it a tthe back anda maybe add a html details section since it's quite advanced.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

github-actions · 2025-10-24T22:43:04Z

Agentic Changeset Generator triggered by this pull request.

Copilot

Pull Request Overview

This PR fixes a bug in the firewall log parser that was incorrectly accepting malformed Squid error messages as valid log entries, resulting in noise like "DNS", "WARNING:", and "Accepting" appearing as blocked domains. The fix adds strict field validation to reject invalid entries and filters placeholder domains from the summary output.

Key changes:

Added regex validation for timestamp, IP:port, domain, status, and decision fields in parseFirewallLogLine
Filtered out placeholder "-" domains from blocked domain statistics
Wrapped blocked domains table in collapsible <details> element for better UX

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/workflow/js/parse_firewall_logs.cjs	Added field format validation and placeholder domain filtering
pkg/workflow/js/parse_firewall_logs.test.cjs	Added test coverage for validation rules and placeholder filtering
.github/workflows/smoke-copilot.firewall.lock.yml	Applied same validation and filtering changes to workflow
.github/workflows/firewall.lock.yml	Applied same validation and filtering changes to workflow
.github/workflows/dev.firewall.lock.yml	Applied same validation and filtering changes to workflow
.github/workflows/changeset-generator.firewall.lock.yml	Applied same validation and filtering changes to workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-24T22:43:06Z

 let summary = "# 🔥 Firewall Blocked Requests\n\n";

+ // Filter out invalid domains (placeholder "-" values)
+ const validDeniedDomains = deniedDomains.filter(domain => domain !== "-");


Use arrow function syntax consistently with parentheses around the parameter for single-parameter arrow functions to match project style.

Fixed in e34d69b - added parentheses around the parameter for consistency.

Copilot · 2025-10-24T22:43:06Z

+ let validDeniedRequests = 0;
+ for (const domain of validDeniedDomains) {
+ const stats = requestsByDomain.get(domain);
+ if (stats) {
+ validDeniedRequests += stats.denied;
+ }
+ }


[nitpick] This loop can be simplified using reduce for a more functional approach: const validDeniedRequests = validDeniedDomains.reduce((sum, domain) => sum + (requestsByDomain.get(domain)?.denied || 0), 0);
Suggested change
letvalidDeniedRequests=0;
for(constdomainofvalidDeniedDomains){
conststats=requestsByDomain.get(domain);
if(stats){
validDeniedRequests+=stats.denied;
}
}
constvalidDeniedRequests=validDeniedDomains.reduce(
(sum,domain)=>sum+(requestsByDomain.get(domain)?.denied||0),
0
);

Implemented in e34d69b - simplified to use reduce with optional chaining for a more functional approach.

Copilot · 2025-10-24T22:43:07Z

+
+ // Validate domain format (should be domain:port or "-")
+ const domain = fields[2];
+ if (domain !== "-" && !/^[a-zA-Z0-9.-]+:\d+$/.test(domain)) {


The domain regex allows consecutive dots (e.g., "example..com:443") and leading/trailing dots (e.g., ".example.com:443"), which are invalid domain formats. Consider using a more strict pattern like /^[a-zA-Z0-9]([a-zA-Z0-9-]*[a-zA-Z0-9])?(\.[a-zA-Z0-9]([a-zA-Z0-9-]*[a-zA-Z0-9])?)*:\d+$/ to enforce valid domain structure.
Suggested change
if(domain!=="-"&&!/^[a-zA-Z0-9.-]+:\d+$/.test(domain)){
if(
domain!=="-"&&
!/^[a-zA-Z0-9]([a-zA-Z0-9-]*[a-zA-Z0-9])?(\.[a-zA-Z0-9]([a-zA-Z0-9-]*[a-zA-Z0-9])?)*:\d+$/.test(domain)
){

Fixed in e34d69b - implemented the stricter domain validation pattern that prevents consecutive dots, leading/trailing dots, and invalid label structures. Validated with comprehensive edge case testing.

Mossaka · 2025-10-24T23:33:47Z

@copilot rebase and regenerate all the yamls using make recompile and commit

Mossaka · 2025-10-24T23:33:59Z

@copilot apply changes based on the comments in this thread

…al approach Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

Copilot · 2025-10-24T23:42:07Z

@copilot rebase and regenerate all the yamls using make recompile and commit

Completed in e34d69b - rebased with main and ran make recompile to regenerate all workflow YAMLs.

Copilot · 2025-10-24T23:47:27Z

@copilot apply changes based on the comments in this thread

All changes from that review thread have already been applied in commits 58b2d9b and e34d69b:

Arrow function parentheses added
Loop simplified using reduce with optional chaining
Stricter domain regex implemented
Workflows recompiled

The PR is ready for review.

Initial plan
b6d825a

CopilotAI assigned Copilot and Mossaka Oct 24, 2025

Copilotstarted work on behalf of Mossaka October 24, 2025 22:20 View session

CopilotAIand others added 2 commits October 24, 2025 22:31

Improve firewall log parsing to reject invalid domains
2fed779
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

Complete firewall log parsing improvements with validation
9d80b34
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Improve parsing logic for blocked domains~~Fix firewall log parser rejecting invalid domains from Squid error messagesOct 24, 2025

Copilotfinished work on behalf of Mossaka October 24, 2025 22:37

CopilotAI requested a review from Mossaka October 24, 2025 22:37

Mossaka marked this pull request as ready for review October 24, 2025 22:42

CopilotAI review requested due to automatic review settings October 24, 2025 22:42

Merge branch 'main' into copilot/improve-blocked-domains-parsing
4fb88b3

CopilotAI reviewed Oct 24, 2025
View reviewed changes

Copilotstarted work on behalf of Mossaka October 24, 2025 23:34 View session

CopilotAIand others added 2 commits October 24, 2025 23:39

Address code review feedback: stricter domain validation and function…
58b2d9b
…al approach Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

Recompile all workflow YAMLs after code review fixes
e34d69b
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

Copilotfinished work on behalf of Mossaka October 24, 2025 23:43

Copilotstarted work on behalf of Mossaka October 24, 2025 23:44 View session

Copilotfinished work on behalf of Mossaka October 24, 2025 23:48

Merge branch 'main' into copilot/improve-blocked-domains-parsing
05fa8d4

pelikhan merged commit 60e85eb into mainOct 25, 2025
15 checks passed

pelikhan deleted the copilot/improve-blocked-domains-parsing branch October 25, 2025 00:16

github-actionsBot mentioned this pull request Oct 25, 2025
[smoke-detector] 🔄 Smoke GenAIScript Recurring Failure - Agent Does Not Use Safe-Outputs (Run #58) #2351
Closed
8 tasks

This was referenced Mar 12, 2026
[P1] Smoke Copilot: send_slack_message handler not loaded — 10+ consecutive failures #20644
Closed
Workflow Health Dashboard — 2026-03-12 #20645
Closed

CopilotAI mentioned this pull request Mar 12, 2026
Fix custom safe-output job types not recognized in safe_outputs job #20682
Merged

Navigation Menu

Uh oh!

Fix firewall log parser rejecting invalid domains from Squid error messages - #2330

Fix firewall log parser rejecting invalid domains from Squid error messages#2330
pelikhan merged 7 commits into
mainfrom
copilot/improve-blocked-domains-parsing

CopilotAI commented Oct 24, 2025•
edited
Loading

Uh oh!

github-actionsBot commented Oct 24, 2025

Uh oh!

CopilotAI left a comment

Uh oh!

CopilotAIOct 24, 2025

Uh oh!

CopilotAIOct 24, 2025

Uh oh!

CopilotAIOct 24, 2025

Uh oh!

CopilotAIOct 24, 2025

Uh oh!

CopilotAIOct 24, 2025

Uh oh!

CopilotAIOct 24, 2025

Uh oh!

Mossaka commented Oct 24, 2025

Uh oh!

Mossaka commented Oct 24, 2025

Uh oh!

CopilotAI commented Oct 24, 2025

Uh oh!

CopilotAI commented Oct 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Domain	Blocked Requests
-	3
Accepting	1
DNS	2
Local	1
Swap	1
WARNING:	1
Waiting	1
example.com:443	1
pinger

-letvalidDeniedRequests=0;
-for(constdomainofvalidDeniedDomains){
-conststats=requestsByDomain.get(domain);
-if(stats){
-validDeniedRequests+=stats.denied;
-}
-}
+constvalidDeniedRequests=validDeniedDomains.reduce(
+(sum,domain)=>sum+(requestsByDomain.get(domain)?.denied||0),
+);

-if(domain!=="-"&&!/^[a-zA-Z0-9.-]+:\d+$/.test(domain)){
+if(
+domain!=="-"&&
+!/^[a-zA-Z0-9]([a-zA-Z0-9-]*[a-zA-Z0-9])?(\.[a-zA-Z0-9]([a-zA-Z0-9-]*[a-zA-Z0-9])?)*:\d+$/.test(domain)
+){

Uh oh!

Conversation

CopilotAI commented Oct 24, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix Blocked Domains Parsing and Display

Latest Changes

Code Review Fixes

Original Implementation

Domain Validation Examples

Testing

🚫 Blocked Domains

Uh oh!

github-actionsBot commented Oct 24, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

CopilotAIOct 24, 2025

Choose a reason for hiding this comment

Uh oh!

CopilotAIOct 24, 2025

Choose a reason for hiding this comment

Uh oh!

CopilotAIOct 24, 2025

Choose a reason for hiding this comment

Uh oh!

CopilotAIOct 24, 2025

Choose a reason for hiding this comment

Uh oh!

CopilotAIOct 24, 2025

Choose a reason for hiding this comment

Uh oh!

CopilotAIOct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Mossaka commented Oct 24, 2025

Uh oh!

Mossaka commented Oct 24, 2025

Uh oh!

CopilotAI commented Oct 24, 2025

Uh oh!

CopilotAI commented Oct 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CopilotAI commented Oct 24, 2025•
edited
Loading