Uh oh!
There was an error while loading. Please reload this page.
chore(deps): use pnpm workspace anchor for vitest versions - #3215
Merged
Conversation
renovateBotforce-pushed
the
renovate/vite-plus-vitest
branch
2 times, most recently
from
August 22, 2026 12:02
955fb3e to
d15ebaaComparerenovateBotforce-pushed
the
renovate/vite-plus-vitest
branch
from
August 22, 2026 13:11
d15ebaa to
8799c3fComparesetchy
commented
Aug 22, 2026
Member
Failure is due to |
renovateBotforce-pushed
the
renovate/vite-plus-vitest
branch
2 times, most recently
from
August 24, 2026 11:12
1226ede to
146e800ComparerenovateBotforce-pushed
the
renovate/vite-plus-vitest
branch
from
August 24, 2026 11:19
146e800 to
23298b6CompareThis reverts commit 8799c3f.
vite-plus 0.2.9 hard-pins vitest 4.1.10 internally and vp test runs through that copy, so renovate's grouped bump to vitest 4.1.11 loaded two incompatible copies into the test workers and broke every rejects/.resolves.toThrow() assertion (152 failures). - drop @vitest/browser: bundled by vite-plus, nothing imports it - pin vitest/@vitest/browser-playwright/@vitest/coverage-v8 in pnpm-workspace.yaml overrides so a split can never resolve at runtime - replace the two renovate holds with a single cap on the vitest family, kept only to avoid no-op PRs while vite-plus still bundles 4.1.10
…-app/gitify into renovate/vite-plus-vitest # Conflicts: # package.json # pnpm-lock.yaml
Move the vitest family versions (vitest, @vitest/browser-playwright, @vitest/coverage-v8) into pnpm-workspace.yaml's catalog and reference them via catalog: in package.json, with the overrides following the catalog (electron-style). The catalog is now the single source of truth. Drop the static allowedVersions hold in renovate.json. The global override referencing the catalog forces every copy - including vite-plus's bundled vitest - onto one version, so a renovate bump of the catalog while vite-plus lags can no longer split the copies that broke every rejects/.resolves.toThrow() assertion. Verified: forcing the catalog to 4.1.11 (vite-plus still 0.2.9) keeps all 1373 tests green.
ContributorAuthor
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
afonsojramos
commented
Aug 24, 2026
Member
@setchy does that really solve the issue here? |
setchy
commented
Aug 24, 2026
Member
WIP - wifi on my flight was patchy. Marking as draft |
setchy
marked this pull request as draft
August 24, 2026 17:27
…th YAML anchor electron was hardcoded in package.json (43.2.0) AND in pnpm-workspace.yaml's catalog, duplicating the version in two places. Point it at catalog: so the catalog is the single source of truth, matching the vitest family. The vitest family (vitest, @vitest/browser-playwright, @vitest/coverage-v8) shares one bundled version; use a YAML anchor so the version is defined once instead of repeated three times.
Signed-off-by: Adam Setch <adam.setch@outlook.com>
setchy
marked this pull request as ready for review
August 24, 2026 19:32
setchy
commented
Aug 24, 2026
Member
not a complete fix, but a step or two in the right direction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.1.10→4.1.114.1.10→4.1.114.1.10→4.1.114.1.10→4.1.11Release Notes
vitest-dev/vitest (@vitest/browser)
v4.1.11Compare Source
🐞 Bug Fixes
View changes on GitHub
Configuration
📅 Schedule: (UTC)
* 0-3 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.